aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-09-18Fix the Internal Field Seperator when using ethtoolGilles Oivier
ethtool.sh didn't reset the Internal Field Seperator (IFS) properly. It now does, by storing the old IFS to OIFS, which will be used later in the for loop. It also fixes the "ethtool_ring_<if>" option. Reported-by: Alois Schmid <alois.schmid@gmx.de> X-Gentoo-Bug: 368525 X-Gentoo-Bug-URL: https://bugs.gentoo.org/368525
2011-09-17Improve missing openvpn/usermode-utilities warning messageChristian Ruppert
as OpenRC can be used on other distributions as well.
2011-09-17Parse broadcast arp responses via arping (iputils) properlyStefan Knoblich
ARP replies may/do contain two MAC addresses when using iputils's arping so we have to use the first one because it's always the "From" address - which is what we want. Thanks to Stefan Knoblich <s.knoblich@axsentis.de> for the fixed pattern. Reported-by: cl@exomail.to X-Gentoo-Bug: 379181 X-Gentoo-Bug-URL: https://bugs.gentoo.org/379181
2011-09-16Print a warning if openvpn/tunctl are missingChristian Ruppert
2011-09-12Revert "Mount /run as early as possible"Christian Ruppert
This reverts commit 5ed4d084d95608e40cb21888c18a8f381a44cd69. /run needs to be mounted after /proc.
2011-09-11Fix regex pattern for umounts during shutdownChristian Ruppert
This patch fixes the regex pattern for /lib -> /lib(32|64)? as well as the pattern for RC_SVCDIR if it contains /lib(32|64)?/. This fixes bug 381783. X-Gentoo-Bug: 381783 X-Gentoo-Bug-URL: https://bugs.gentoo.org/381783
2011-09-08release openrc-0.9.3William Hubbs
2011-09-08Credits for previous commitWilliam Hubbs
Reported-By: i.Dark_Templar <dark_templar@hotbox.ru> X-Gentoo-Bug: 381783 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=381783
2011-09-08Use the real/actual path when looking for mountsChristian Ruppert
/proc/mounts contains real/actual paths so we should do the same in mountinfo.
2011-09-08Remove unused variableChristian Ruppert
2011-09-07Use checkpath to create /run/lockWilliam Hubbs
2011-09-06Mount /run as early as possibleWilliam Hubbs
This commit moves the code that mounts /run to the earliest possible position in openrc.
2011-09-02release openrc-0.9.2William Hubbs
2011-09-02Do not ignore return code for custom script functionsFlex
X-Gentoo-Bug: 380317 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=380317
2011-09-02Mtab: fix typoWilliam Hubbs
Reported-By: Helmuth Schmelzer <des-colo@hotmail.com> X-Gentoo-Bug: 381503 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=381503
2011-09-01release openrc-0.9.1William Hubbs
2011-09-01Start-stop-daemon: remove call to pam_authenticateDiego
2011-09-01release openrc-0.9.0William Hubbs
2011-08-22Libeinfo: do not suppress ewarn() messagesWilliam Hubbs
The ewarn() function was affected by the EINFO_QUIET environment variable which lead to warning messages being suppressed. Warnings should not be suppressed. Reported-by: Hanno Boeck <hanno@gentoo.org> X-Gentoo-Bug: 380073 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=380073
2011-08-20Do not print "null" or "noop" when configuring an interfaceYun Zheng Hu
Note by william hubbs: I modified the patch to compare "null" and "noop" with $1 instead of ${config}. Reported-by: Yun Zheng Hu <hu@fox-it.com> X-Gentoo-Bug: 379577 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=379577
2011-08-20Do not update mtab if it is a symbolic linkWilliam Hubbs
Reported-by: <junkmailnotread@yahoo.com> X-Gentoo-Bug: 370037 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=370037
2011-07-31Improve processing of service directories and conf.d filesWilliam Hubbs
symbolic links should not be followed in an attempt to work out the name of the service we are running. Also, @sysconfdir@/conf.d should be tried as a backup directory for configuration files. I would like to thank Robin Johnson for his input on this change. X-Gentoo-Bug: 350910 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=350910
2011-07-28swclock: select a default reference fileWilliam Hubbs
If $RC_SVCDIR/shutdowntime does not exist, we need a default reference file. It is safe to use @PREFIX@/sbin/runscript for this purpose. Reported-By: Robin H. Johnson <robbat2@gentoo.org> X-Gentoo-Bug: 376249 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=376249
2011-07-26runscript: rename saveDir back to save to fix compile errorWilliam Hubbs
2011-07-26Runscript: print deprecation warning for opts variableWilliam Hubbs
Openrc uses the extra_commands and extra_started_commands variables to list extra commands for services. Also, it supports the opts variable which is used to assist migration from baselayout-1. I am adding this warning to encourage switching from opts to extra_commands/extra_started_commands. I would like to remove support for opts eventually.
2011-07-26mtab: fix test for a link to a location in /procWilliam Hubbs
/etc/mtab can be a link to a file in /proc. If it is, we should not attempt to update /etc/mtab. The original test used "! -w" as part of the test. This does not work since everything is writeable by root. Thanks to Robin Johnson for the suggestion of using readlink -f and the regular expression. Reported-By: junkmailnotread@yahoo.com X-Gentoo-Bug: 370037 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=370037
2011-07-23Mtab: fix typoWilliam Hubbs
2011-07-20rename save and save2 for clarityWilliam Hubbs
The names saveDir and saveLnk seem to better define how these variables are used.
2011-07-18Rewrite iproute2 addr argument parsing.Robin H. Johnson
This was originally to fix the fact that our code did not handle certain orders of arguments in conversion, but it was easier to rewrite the entire argument handling to support more options at the same time. Now supports all options documented in the ip manpage, including the IPv6-specific options that must be passed after the interface argument. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> Reported-by: Tony Vroon <chainsaw@gentoo.org> X-Gentoo-Bug: 366905 X-Gentoo-Bug-URL: https://bugs.gentoo.org/366905
2011-07-14Add warnings for the use of bash arraysWilliam Hubbs
Currently, we allow the use of bash arrays for some configuration settings. This is undocumented, so I want to remove the support from openrc. The first phase of this removal will be this commit which adds warnings to encourage people not to use bash arrays. X-Gentoo-Bug: 374875 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=374875
2011-07-13Add commit message information to style guideWilliam Hubbs
2011-07-13Fix rc_service_value_get() to return multiple lines as wellChristian Ruppert
As introduced in bug 372547 using service_get_value() in the init scripts or using rc_service_value_get() directly will only return one line. This patch fixes it by using the new rc_getfile() function, it returns even multiple lines. We're still using a char *, so the lines will be appended instead of added into new element. X-Gentoo-Bug: 372547 X-Gentoo-Bug-URL: http://bugs.gentoo.org/372547
2011-07-13Add a new function, bool rc_getfile(const char *, char **, size_t *)Mike Frysinger
<snip> Read the entire @file into the buffer and set @len to the size of the buffer when finished. For C strings, this will be strlen(buffer) + 1. Don't forget to free the buffer afterwards! </snip> We also fix bug 374899 by adding this new function. X-Gentoo-Bug: 374899 X-Gentoo-Bug-URL: http://bugs.gentoo.org/374899
2011-07-09Do not skip similar config optionsChristian Ruppert
OpenRC goes through the config and checks each option for duplicates. Lets say we're on "rc_logger" currently and its the last option in the config file and we previously defined rc_logger_path. It now goes through all previous config options and compares those against the current one "rc_logger" *but* it compares only the first N bytes, in this case strlen("rc_logger"). So it strips the _path from "rc_logger_path" which ends up into "rc_logger" and it compares that against the current one (also "rc_logger"), it would then simply override the previous definition. This patch fixes this behaviour to always compare the full option / variable names.
2011-07-07save and restore IFS correctlyKirill Elagin
X-Gentoo-Bug: 371141 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=371141
2011-07-06rc_log_path should be quotedWilliam Hubbs
2011-07-06Rename rc_logger_path to rc_log_pathChristian Ruppert
2011-07-06The is_net_fs function should use extra_net_fs_listWilliam Hubbs
This was pointed out to me by Morse on #gentoo-base, so I would like to thank him for the patch.
2011-07-05fix issue with extra_net_fs_listWilliam Hubbs
The extra_net_fs_list variable was not being included as it should have been for the net file systems because it was being expanded before it was set by the user. X-Gentoo-Bug: 374133 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=374133
2011-07-06Document the new rc_logger_path optionChristian Ruppert
2011-07-05Improve loggingChristian Ruppert
Add "e" (O_CLOEXEC) to all fopen() calls. Remove system() call and replace it by fopen() and friends. This also fixes bug 368933 X-Gentoo-Bug: 368933 X-Gentoo-Bug-URL: https://bugs.gentoo.org/368933
2011-07-05Don't write into optarg, this also fixes a compiler warning.Christian Ruppert
2011-07-04eat trailing whitespaceMike Frysinger
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-07-04Bug 373808: init.d/modules skipped certain variable combinationsRobin H. Johnson
The version iteration code missed certain combinations: KV=1.2.3.4 skips: 1.2.3, 1 KV=1.2.3 skips: 1 Simplify the code to use a loop and build the list of versions directly instead of unique variables per version component. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
2011-07-02slight formatting changeWilliam Hubbs
Add a new line after "rc_runlevel()" for consistency.
2011-06-30Add --startas/-a back to the optstringChristian Ruppert
X-Gentoo-Bug: 373609 X-Gentoo-Bug-URL: https://bugs.gentoo.org/373609
2011-06-29drop useless "All rights reserved" noticeMike Frysinger
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-06-28Use RC_CONF instead of the hardcoded /etc/rc.confChristian Ruppert
2011-06-28net: ccwgroup: smooth up/down processMike Frysinger
We need to bring the link up ourselves after we've properly configured the device. The common code tries to bring the link up itself, but it does so before things are configured, and so it ends up failing. When shutting down, we need to wait for the kernel to finish destroying the interface. Otherwise, when doing a restart, openrc is quick enough to tell the kernel to destroy things, but then start trying to bring it back up before the kernel has finished. X-Gentoo-Bug: 367467 X-Gentoo-Bug-URL: http://bugs.gentoo.org/367467 Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-06-27Only print the deprecation warning for --chuid/-c when using itJoe Harvell
The deprecation warning has been printed when using the replecement functions as well, bug 373243.