aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-23check whether /sys/fs/cgroup is a mountpointChristian Brauner
The current check only tries to detect whether /sys/fs/cgroup exists and whether it is writable or not. But when the init system doesn't mount cgroups then /sys/fs/cgroup will just be an empty directory. When paired with unprivileged containers that mount sysfs this will cause misleading errors to be printed since /sys/fs/cgroup will be owned by user nobody:nogroup in this case. Independent of this specific problem this check will also be misleading when the /sys/fs/cgroup exists and is in fact writable by the init system but isn't actually a mountpoint. Note from William. "grep -qs" doesn't need to redirect output to /dev/null since it is completely silent. This fixes #209.
2018-02-23improve cgroup configuration checksWilliam Hubbs
make the base/controller functions return successfully if cgroups v1/v2 are not configured in the kernel
2018-02-22openrc: force deptree update for sysinit runlevelWilliam Hubbs
2018-02-22supervise-daemon: zero out the cmdline buffer when it is allocatedWilliam Hubbs
2018-02-21start-stop-daemon: compiler warning cleanupWilliam Hubbs
2018-02-21openrc-run: clean up a compiler warningWilliam Hubbs
2018-02-21supervise-daemon: remove references to PATH_MAXWilliam Hubbs
2018-02-21rc.c: remove PATH_MAX referencesWilliam Hubbs
2018-02-20rc-selinux.c: remove references to path_maxWilliam Hubbs
2018-02-20rc-plubin.c: remove references to PATH_MAXWilliam Hubbs
2018-02-20rc-misc.c: remove references to PATH_MAXWilliam Hubbs
2018-02-16start-stop-daemon: clean up string handlingWilliam Hubbs
2018-02-15openrc-run: clean up string handlingWilliam Hubbs
- remove references to PATH_MAX - use xasprintf to create strings
2018-02-15rc-update: remove reference to PATH_MAXWilliam Hubbs
2018-02-14mountinfo: create strings with xasprintfWilliam Hubbs
2018-02-14kill_all: create strings with xasprintfWilliam Hubbs
2018-02-10helpers.h: silence compiler warnings about xasprintfWilliam Hubbs
2018-02-10xasprintf: exit if return value of vsnprintf is invalidWilliam Hubbs
2018-02-09helpers.h: add xasprintf functionWilliam Hubbs
This is our own version of asprintf(). This original code was written by Mike Frysinger, and I was able to modify it to use our memory helper functions. We need a version of this code because it is not available on glibc at least without defining _GNU_SOURCE, and I would rather not do that. This is the first step in improving string handling in OpenRC for #207.
2018-02-09helpers.h: style fixWilliam Hubbs
2018-02-06man/openrc-run.8: fix mountinfo args.Michael Orlitzky
The "Ar" tag for the mountinfo command contained a typo (leading space) that resulted in the tag being output verbatim; that is, mountinfo ... .Ar mount1 mount2 rather than e.g. mountinfo ... <mount1> <mount2> This commit deletes the leading space to fix the output. This fixes #204.
2018-02-06man/openrc-run.8: add missing "Xo" tags for fstabinfo and mountinfo.Michael Orlitzky
The BUILTINS are all surrounded by Xo...Xc tags, but the opening "Xo" was missing from the two commands fstabinfo and mountinfo. This commit adds them, and thereby fixes the spacing when viewed by man. This is for #204.
2018-01-24service-script-guide.md cleanupsWilliam Hubbs
Refer to /var/run in the documentation instead of /run, and make it clear at the top of the pidfile section that we use /run under Linux. This is for #202.
2018-01-24typo fixWilliam Hubbs
2018-01-23checkpath: use fchown and fchmod to handle ownership and mode changesWilliam Hubbs
This is related to #195. This is an attempt to shorten the window for the first two issues discussed by using a file descriptor which does not follow symbolic links and using the fchmod and fchown calls instead of chown and chmod. with.
2018-01-16checkpath: fix lchown error messageWilliam Hubbs
X-Gentoo-Bug: 643084 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=643084
2018-01-16_rc_deptree_load - return NULL if the stat() call is not successfulWilliam Hubbs
X-Gentoo-Bug: 643084 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=643084
2018-01-12Reformat and fix titles in documentationWilliam Hubbs
2018-01-11Rename guide.md to user-guide.md to better describe its purposeWilliam Hubbs
2018-01-10move developer documentation from guide.md to service-script-guide.mdWilliam Hubbs
2018-01-09checkpath: use lchown instead of chownWilliam Hubbs
Checkpath should never follow symbolic links when changing ownership of a file. This is for https://github.com/openrc/openrc/issues/195.
2018-01-08service-script-guide.md: formatting changesWilliam Hubbs
Add a title, adjust the headings and update the example that referred to "net.lo" to refer to "loopback".
2018-01-08service-script-guide.md: new guide for service script authors.Michael Orlitzky
This fixes #162.
2018-01-05net-online: only process symbolic links in /sys/class/net3PO
The /sys/class/net directory contains files which are not symlinks if the system has bonded devices [1]. We should ignore these files. This fixes #196. [1] https://elkano.org/blog/manage-interface-bondings-sysfs-interface/
2017-12-20init.d.examples: pid files always go in /varWilliam Hubbs
This removes the @VARBASE@ substitution since it is always translated to /var.
2017-12-14procfs: remove the @sysconfdir@ referenceWilliam Hubbs
2017-12-14hostname: replace @SYSCONFDIR@ references with /etcWilliam Hubbs
I do not know of any situation where /etc/hostname is at any other location. Also, this does not run on prefix.
2017-12-14hwclock: use shell variables for configuration file pathWilliam Hubbs
This removes a reference to @SYSCONFDIR@.
2017-12-14sysctl: hard code paths for sysctl files on *bsdWilliam Hubbs
For *BSD,the sysctl*.conf files are always in /etc.
2017-12-14local: misc cleanupsWilliam Hubbs
Remove references to @SYSCONFDIR@ since these can be calculated at runtime. Also style fixes.
2017-12-14devfs: cleanupWilliam Hubbs
clean up local definitions. Also remove @SYSCONFDIR@ substitutions since they can be calculated at runtime.
2017-12-12net-online: wait for ping_test_hostbell07
The script should wait till the ping host is available or timeout reached Closes : #179 Closes : #191
2017-12-12network: use 'command -v ip' to test for the ip executableWilliam Hubbs
This is an improved test because it doesn't require the ip executable to be in a specific path.
2017-12-12Do not use file tests in net-onlineWilliam Hubbs
https://unix.stackexchange.com/questions/252002/help-testing-special-file-in-sys-class-net This is for #189
2017-12-11net-online: clean up quoting and test for existenceWilliam Hubbs
This is for #178.
2017-12-11Gracefully handle unreadable /sys/class/net/dev/ nodesMarcel Greter
Fixes https://bugs.gentoo.org/629228 Fixes #189 Fixes #185 Fixes #178
2017-12-07Make bash-completion and zsh-completion optionalWilliam Hubbs
2017-12-07Add zsh-completion supportWilliam Hubbs
2017-12-06add bash completion supportWilliam Hubbs
This fixes #188.
2017-12-04rc-service: add --ifcrashed optionWilliam Hubbs
This works like the other --if options. If the service is crashed, run the command. This fixes #154.