From 0b9c3c080388476519ac3385c21518cc5a94735a Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Thu, 2 Feb 2023 11:19:00 +0900 Subject: openrc-run: silence lock failures with --no-deps work around scary warnings described in previous commit --- src/shared/misc.c | 12 ++++++++++-- src/shared/misc.h | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) (limited to 'src/shared') diff --git a/src/shared/misc.c b/src/shared/misc.c index 28f95b34..c987ce8c 100644 --- a/src/shared/misc.c +++ b/src/shared/misc.c @@ -234,7 +234,7 @@ signal_setup_restart(int sig, void (*handler)(int)) } int -svc_lock(const char *applet) +svc_lock(const char *applet, bool ignore_lock_failure) { char *file = NULL; int fd; @@ -245,6 +245,14 @@ svc_lock(const char *applet) if (fd == -1) return -1; if (flock(fd, LOCK_EX | LOCK_NB) == -1) { + if (ignore_lock_failure) { + /* Two services with a need b, and b's start() + * calling restart --no-deps on a would cause + * harmless errors: just ignore them. + * See https://github.com/OpenRC/openrc/issues/224 + */ + exit(EXIT_SUCCESS); + } eerror("Call to flock failed: %s", strerror(errno)); close(fd); return -1; @@ -274,7 +282,7 @@ exec_service(const char *service, const char *arg) sigset_t old; struct sigaction sa; - fd = svc_lock(basename_c(service)); + fd = svc_lock(basename_c(service), false); if (fd == -1) return -1; diff --git a/src/shared/misc.h b/src/shared/misc.h index 099206c8..f4ab25ad 100644 --- a/src/shared/misc.h +++ b/src/shared/misc.h @@ -50,7 +50,7 @@ void env_filter(void); void env_config(void); int signal_setup(int sig, void (*handler)(int)); int signal_setup_restart(int sig, void (*handler)(int)); -int svc_lock(const char *); +int svc_lock(const char *, bool); int svc_unlock(const char *, int); pid_t exec_service(const char *, const char *); -- cgit v1.2.3