From 9c0edc5c527de01cbe2dccbc7f1a2c571b6acc41 Mon Sep 17 00:00:00 2001 From: Christian Ruppert Date: Tue, 17 Jan 2012 18:23:56 +0100 Subject: Use the "--make-pidfile" when command_background is used The start-stop-daemon "--make-pidfile" option is now used by default when using command_background, this requires a pidfile to be specified. Document command_background option. Reported-by: Giampaolo Tomassoni X-Gentoo-Bug: 399165 X-Gentoo-Bug-URL: https://bugs.gentoo.org/399165 --- sh/runscript.sh.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'sh/runscript.sh.in') diff --git a/sh/runscript.sh.in b/sh/runscript.sh.in index 470f04c6..e042be6d 100644 --- a/sh/runscript.sh.in +++ b/sh/runscript.sh.in @@ -124,7 +124,11 @@ start() local _background= ebegin "Starting ${name:-$RC_SVCNAME}" if yesno "${command_background}"; then - _background="--background --pidfile" + if [ -z "${pidfile}" ]; then + eend 1 "command_background option used but no pidfile specified" + return 1 + fi + _background="--background --make-pidfile --pidfile" fi if yesno "$start_inactive"; then local _inactive=false -- cgit v1.2.3