diff options
| author | NRK <nrk@disroot.org> | 2023-01-31 04:16:41 +0600 |
|---|---|---|
| committer | Mike Frysinger <vapier@gmail.com> | 2023-02-05 00:38:20 -0500 |
| commit | 63a5ee3d8c75db0ce89a755264f0d871107668d3 (patch) | |
| tree | daaf72b7767d29bed504d5348934a116c7e9dc09 /src | |
| parent | 36cc40a9d641058ae69ca64a4661d5900098ab12 (diff) | |
seedrng: fix memory leak reported by clang-tidy
`seed_dir` gets allocated via xstrdup but never gets freed - which
clang-tidy flags as a memory leak.
instead of free-ing the allocation, just don't allocate to begin with
since there's no need for it.
also bump the copyright year.
Diffstat (limited to 'src')
| -rw-r--r-- | src/seedrng/seedrng.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/seedrng/seedrng.c b/src/seedrng/seedrng.c index 5d3b9584..3bffa0bb 100644 --- a/src/seedrng/seedrng.c +++ b/src/seedrng/seedrng.c @@ -5,7 +5,7 @@ */ /* - * Copyright (c) 2022 The OpenRC Authors. + * Copyright (c) 2023 The OpenRC Authors. * See the Authors file at the top-level directory of this distribution and * https://github.com/OpenRC/openrc/blob/HEAD/AUTHORS * @@ -455,7 +455,7 @@ int main(int argc, char **argv) static const char seedrng_prefix[] = "SeedRNG v1 Old+New Prefix"; static const char seedrng_failure[] = "SeedRNG v1 No New Seed Failure"; int opt, fd, dfd, program_ret = 0; - char *seed_dir = NULL; + const char *seed_dir = NULL; uint8_t new_seed[MAX_SEED_LEN]; size_t new_seed_len; bool new_seed_creditable; @@ -470,7 +470,7 @@ int main(int argc, char **argv) switch (opt) { case LONGOPT_SEED_DIR: if (!seed_dir) - seed_dir = xstrdup(optarg); + seed_dir = optarg; break; case LONGOPT_SKIP_CREDIT: skip_credit = true; @@ -479,7 +479,7 @@ int main(int argc, char **argv) } } if (!seed_dir) - seed_dir = xstrdup(DEFAULT_SEED_DIR); + seed_dir = DEFAULT_SEED_DIR; if (getuid()) eerrorx("%s: superuser access is required", applet); umask(0077); |