diff options
| author | Christian Ruppert <idl0r@gentoo.org> | 2012-04-26 10:16:56 +0200 |
|---|---|---|
| committer | Christian Ruppert <idl0r@gentoo.org> | 2012-04-26 10:33:54 +0200 |
| commit | fd6bbfbe0713b07d050f0318610ebd479735c661 (patch) | |
| tree | 737bdaceee23b15ce13cab5beaa4a991fc606b6e /scripts/Makefile | |
| parent | a6549a2b0ffc087bbf7b0ea41cf8dd5bda64e680 (diff) | |
Disable some questionable lines
Caused by bug 412589 I was looking at the do_mark_service() function and quickly
found that the segfault is caused by a strlen() call against a NULL pointer.
I also noticed it's using "/exclusive/%s.%s" so svcname.pid, all other functions
are just using the svcname.. So it seems that svcname.pid was/is never used and
thus not necessary at all.
In relation to the above, the if statement in the do_mark_service() function
("if (ok && svcname && strcmp(svcname, service) == 0) {") needs to be
fixed/improved as svcname and service are almost always equal, see my comment in
the function for further details.
Signed-off-by: Christian Ruppert <idl0r@gentoo.org>
Reported-by: Patrick McLean <chutzpah@gentoo.org>
X-Gentoo-Bug: 412589
X-Gentoo-Bug-URL: https://bugs.gentoo.org/412589
Diffstat (limited to 'scripts/Makefile')
0 files changed, 0 insertions, 0 deletions