openrc.git/src/openrc, branch master

rc.c, openrc-pam.c: move lockfile code into pam module

2023-10-19T08:56:54+00:00

since we now assure that XDG_RUNTIME_DIR is set in the pam environment, we can handle the lock file in there instead, which makes way more sense for me at least. Signed-off-by: Anna (navi) Figueiredo Gomes

rc.c: use a flag instead of environment variables change the lockfile

2023-10-19T08:56:54+00:00

Signed-off-by: Anna (navi) Figueiredo Gomes

openrc: rework pathing functions

2023-10-19T08:56:54+00:00

this simplifies the allocation of path string. also fixes some memory leaks from the ealier commit also changes the log path for users to XDG_CACHE_HOME, default ~/.cache/openrc Signed-off-by: Anna (navi) Figueiredo Gomes

openrc: create lockfile for --user.

2023-10-19T08:56:54+00:00

the pam module sets a variable that when in user mode, openrc should pick up and either create/increment, or decrement. this is done so that multiple session_open and session_close from pam doesn't randomly change the user runlevel for the current user. only the first session open starts the default runlevel, and only the last session close switches to the none runlevel. Signed-off-by: Anna (navi) Figueiredo Gomes

openrc: Add the correct path for logs as user

2023-10-19T08:56:54+00:00

Signed-off-by: Anna (navi) Figueiredo Gomes

openrc: Add support for user services.

2023-10-19T08:56:54+00:00

Modifies many functions where filesystem paths were hardcoded. In non-user-services mode, they still are. In user-services mode, they are allocated, since XDG_ dirs are to be set via environment variables. Signed-off-by: Anna (navi) Figueiredo Gomes

rc: fix automatic restart with runlevel-specific conf.d files

2023-07-27T03:41:42+00:00

Commit fc4f15d6cd8e7884f7094e5d3749b01f2d5a448f broke the automatic restart of services having runlevel-specific conf.d files. The double dirname() was not a mistake, but the way of getting from the service script in init.d to the upper directory containing the conf.d directory. dirname() modifies the argument in-place, so the second call operated on a modified value. To make it more obvious what is going on, have the second call operate on the returned value from the first call. Fixes: fc4f15d ("openrc: fix double-assignment to dir") Signed-off-by: Sven Wegener

rc: use LIST_FOREACH_SAFE in cleanup()

2023-04-25T00:20:19+00:00

according to the linux manpage, the "safe" variant may not be available on all platform. however we bundle our own `queue.h` so this should not be an issue.

rc: block SIGCHLD during pid list operations

2023-04-25T00:20:19+00:00

the pid list will be accessed inside the SIGCHLD signal handler. so we must ensure SIGCHLD handler doesn't get invoked while the list is at an inconsistent state making it unsafe to interact with. Co-authored-by: Dominique MARTINET Bug: https://github.com/OpenRC/openrc/issues/589#issuecomment-1406588576

rc: avoid calling free inside SIGCHLD handler

2023-04-25T00:20:19+00:00

`free` is not async-signal-safe and calling it inside a signal handler can have bad effects, as reported in the musl ML: https://www.openwall.com/lists/musl/2023/01/23/1 the solution: - keep track of weather remove_pid() is being called from inside a signal handler or not. - if it's inside a signal handler then DO NOT call free - instead put that pointer into a "to be freed later" list. - if it's not inside a signal handler then take the "to be freed later" list and free anything in it. Bug: https://github.com/OpenRC/openrc/issues/589 Reported-by: Dominique MARTINET