From 2fc39eb4c35ad6c66a1b832a81d1519dcf5fe856 Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 28 Apr 2015 22:00:48 +0200 Subject: Fix memory leak in async spontaneous reply handling When an asynchronous hiredis connection subscribes to a Pub/Sub channel and gets an error, and in other related conditions, the function redisProcessCallbacks() enters a code path where the link is disconnected, however the function returns before freeing the allocated reply object. This causes a memory leak. The memory leak was trivial to trigger in Redis Sentinel, which uses hiredis, every time we tried to subscribe to an instance that required a password, in case the Sentinel was configured either with the wrong password or without password at all. In this case, the -AUTH error caused the leaking code path to be executed. --- async.c | 1 + 1 file changed, 1 insertion(+) (limited to 'async.c') diff --git a/async.c b/async.c index 84480bc..28aa76f 100644 --- a/async.c +++ b/async.c @@ -454,6 +454,7 @@ void redisProcessCallbacks(redisAsyncContext *ac) { if (((redisReply*)reply)->type == REDIS_REPLY_ERROR) { c->err = REDIS_ERR_OTHER; snprintf(c->errstr,sizeof(c->errstr),"%s",((redisReply*)reply)->str); + c->reader->fn->freeObject(reply); __redisAsyncDisconnect(ac); return; } -- cgit v1.2.3