From ac0b186aa3ec12eb1730f2f58b702c30d3ed5789 Mon Sep 17 00:00:00 2001
From: michael-grunder <michael.grunder@gmail.com>
Date: Thu, 12 Dec 2019 14:40:50 -0800
Subject: Free the reply in redisGetReply when passed NULL

We currently perform a NULL check in redisGetReply and don't push the
reply back to the caller, but we don't free any reply meaning that this
will leak memory:

redisGetReply(context, NULL);

This change simply frees the reply if we were passed NULL.

Addresses #740
---
 hiredis.c | 9 +++++++--
 test.c    | 5 +++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/hiredis.c b/hiredis.c
index c461131..8e438f2 100644
--- a/hiredis.c
+++ b/hiredis.c
@@ -945,8 +945,13 @@ int redisGetReply(redisContext *c, void **reply) {
         } while (aux == NULL);
     }
 
-    /* Set reply object */
-    if (reply != NULL) *reply = aux;
+    /* Set reply or free it if we were passed NULL */
+    if (reply != NULL) {
+        *reply = aux;
+    } else {
+        freeReplyObject(aux);
+    }
+
     return REDIS_OK;
 }
 
diff --git a/test.c b/test.c
index de06973..9c0de6d 100644
--- a/test.c
+++ b/test.c
@@ -591,6 +591,11 @@ static void test_blocking_connection(struct config config) {
               strcasecmp(reply->element[1]->str,"pong") == 0);
     freeReplyObject(reply);
 
+    /* Make sure passing NULL to redisGetReply is safe */
+    test("Can pass NULL to redisGetReply: ");
+    assert(redisAppendCommand(c, "PING") == REDIS_OK);
+    test_cond(redisGetReply(c, NULL) == REDIS_OK);
+
     disconnect(c, 0);
 }
 
-- 
cgit v1.2.3