From b455b33818be4dab51777433fcac0d15e0c221ec Mon Sep 17 00:00:00 2001 From: Yossi Gottlieb Date: Fri, 22 Apr 2022 15:35:55 +0300 Subject: Handle push notifications before or after reply. --- test.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test.c b/test.c index f43bc24..b831680 100644 --- a/test.c +++ b/test.c @@ -914,6 +914,11 @@ static void test_resp3_push_handler(redisContext *c) { old = redisSetPushCallback(c, push_handler); test("We can set a custom RESP3 PUSH handler: "); reply = redisCommand(c, "SET key:0 val:0"); + /* We need another command because depending on the version of Redis, the + * notification may be delivered after the command's reply. */ + test_cond(reply != NULL); + freeReplyObject(reply); + reply = redisCommand(c, "PING"); test_cond(reply != NULL && reply->type == REDIS_REPLY_STATUS && pc.str == 1); freeReplyObject(reply); @@ -929,6 +934,12 @@ static void test_resp3_push_handler(redisContext *c) { assert((reply = redisCommand(c, "GET key:0")) != NULL); freeReplyObject(reply); assert((reply = redisCommand(c, "SET key:0 invalid")) != NULL); + /* Depending on Redis version, we may receive either push notification or + * status reply. Both cases are valid. */ + if (reply->type == REDIS_REPLY_STATUS) { + freeReplyObject(reply); + reply = redisCommand(c, "PING"); + } test_cond(reply->type == REDIS_REPLY_PUSH); freeReplyObject(reply); -- cgit v1.2.3