From 663d6d1258b3ef49178ed4120de5c91ecffe2512 Mon Sep 17 00:00:00 2001
From: Pieter Noordhuis <pcnoordhuis@gmail.com>
Date: Thu, 27 Jan 2011 14:39:34 +0100
Subject: Properly reset state after protocol error in reply reader

---
 hiredis.c | 2 +-
 test.c    | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/hiredis.c b/hiredis.c
index 1017566..cd4ea50 100644
--- a/hiredis.c
+++ b/hiredis.c
@@ -493,7 +493,7 @@ static void redisSetReplyReaderError(redisReader *r, sds err) {
     if (r->buf != NULL) {
         sdsfree(r->buf);
         r->buf = sdsempty();
-        r->pos = 0;
+        r->pos = r->len = 0;
     }
     r->ridx = -1;
     r->error = err;
diff --git a/test.c b/test.c
index 8017356..bc82a1e 100644
--- a/test.c
+++ b/test.c
@@ -318,6 +318,15 @@ static void test_reply_reader(void) {
     ret = redisReplyReaderGetReply(reader,&reply);
     test_cond(ret == REDIS_OK && reply == (void*)REDIS_REPLY_STATUS);
     redisReplyReaderFree(reader);
+
+    test("Properly reset state after protocol error: ");
+    reader = redisReplyReaderCreate();
+    redisReplyReaderSetReplyObjectFunctions(reader,NULL);
+    redisReplyReaderFeed(reader,(char*)"x",1);
+    ret = redisReplyReaderGetReply(reader,&reply);
+    assert(ret == REDIS_ERR);
+    ret = redisReplyReaderGetReply(reader,&reply);
+    test_cond(ret == REDIS_OK && reply == NULL)
 }
 
 static void test_throughput(void) {
-- 
cgit v1.2.3