summaryrefslogtreecommitdiff
path: root/async.c
AgeCommit message (Collapse)Author
2020-07-31Define a no op assert if we detect NDEBUG (#861)Michael Grunder
Addresses #642
2020-07-26add a command_timeout to redisContextOptions (#839)valentinogeron
Add an additional timeout so the user has a convenient way of controlling distinct connect and command timeouts
2020-07-19Resp3 oob push support (#841)Michael Grunder
Proper support for RESP3 PUSH messages. By default, PUSH messages are now intercepted and the reply memory freed. This means existing code should work unchanged when connecting to Redis >= 6.0.0 even if `CLIENT TRACKING` were then enabled. Additionally, we define two callbacks users can configure if they wish to handle these messages in a custom way: void redisPushFn(void *privdata, void *reply); void redisAsyncPushFn(redisAsyncContext *ac, void *reply); See #825
2020-06-22fix #785: defer TCP_NODELAY in async tcp connections (#836)OmriSteiner
Co-authored-by: Omri Steiner <omri@insoundz.com>
2020-05-22Allow users to replace allocator and handle OOM everywhere. (#800)Michael Grunder
* Adds an indirection to every allocation/deallocation to allow users to plug in ones of their choosing (use custom functions, jemalloc, etc). * Gracefully handle OOM everywhere in hiredis. This should make it possible for users of the library to have more flexibility in how they handle such situations. * Changes `redisReaderTask->elements` from an `int` to a `long long` to prevent a possible overflow when transferring the task elements into a `redisReply`. * Adds a configurable `max elements` member to `redisReader` that defaults to 2^32 - 1. This can be set to "unlimited" by setting the value to zero.
2020-05-21Add logic to handle RESP3 push messages (#819)Michael Grunder
Fixes #815
2020-04-09Provides an optional cleanup callback for async data.Nick Rivera
2020-01-28Safe allocation wrappers (#754)Michael Grunder
Create allocation wrappers with a configurable OOM handler (defaults to abort()). See #752, #747
2019-08-29wip: SSL code reorganization, see #705.Yossi Gottlieb
2019-08-09MinGW fix: Use _MSC_VER instead of _WIN32 where appropriateMarcus Geelnard
Use _MSC_VER (instead of _WIN32) for things that are specific for Visual Studio. Also remove #include <winsock2.h> from hiredis.h, as it leaks too many symbols and defines into the global namespace, which is undesirable for a public interface header. Anyone who uses the the affected parts of the hiredis API needs to include the appropriate headers anyway in order to declare struct timeval variables.
2019-07-22Removed whitespace before newlineOdin Hultgren Van Der Horst
- Removed whitespace before newline - Removed win style newline
2019-04-13Fix Compile Error On Windows (Visual Studio)jinjiazhang
2019-03-11Retain the same semantics for connection error on connection timeoutMark Nunberg
This ensures that a disconnect occurs. This commit also ensures that disconnects will clean the socket even if the user is in no-auto-free mode
2019-02-21Allow option for async connections to not automatically freeMark Nunberg
2019-02-20fix potential uninitialized readMark Nunberg
If callback was set before scheduleTimer was set (i..e before one of the attach()) calls.
2019-02-20Allow connectWithOptions for async as wellMark Nunberg
2019-02-20read/write timeoutsMark Nunberg
2019-02-20Don't add dead code for HIREDIS_NOSSLMark Nunberg
We changed this to `HIREDIS_SSL`
2019-02-20SSL for async I/OMark Nunberg
2018-09-25Handle connection errors better in blocking mode as wellMark Nunberg
2018-09-25Call connect(2) again for non-blocking connectMark Nunberg
This retrieves the actual error which occurred, as getsockopt is not always reliable in this regard.
2018-05-09Merge remote-tracking branch 'hyjin/master'michael-grunder
2017-07-15Merge #524 #525not-a-robot[bot]
524: Don't pass a negative value to __redisAsyncCommand if redisFormatSdsCommandArgv fails r=badboy 525: Fix compilation on FreeBSD 10.3 with default compiler r=badboy Given FreeBSD 10.3 with default compiler: > $ cc -v > FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512 > Target: x86_64-unknown-freebsd10.3 Defining _XOPEN_SOURCE to 600 on the fixed line leads to the following errors: > cc -std=c99 -pedantic -c -O3 -fPIC -Wall -W -Wstrict-prototypes -Wwrite-strings -g -ggdb net.c > net.c:435:29: error: use of undeclared identifier 'AF_LOCAL' > if (redisCreateSocket(c,AF_LOCAL) < 0) > ^ > net.c:460:21: error: use of undeclared identifier 'AF_LOCAL' > sa.sun_family = AF_LOCAL; > ^ > 2 errors generated. > AF_LOCAL is defined in sys/socket.h within ifdef __BSD_VISIBLE. __BSD_VISIBLE could be defined in sys/cdefs.h, but it is never done if _XOPEN_SOURCE is defined. So on FreeBSD _XOPEN_SOURCE shouldn't be defined.
2017-06-15Assert statement calls a function which has side effectsamallia
2017-05-15Don't pass a negative value to __redisAsyncCommand if ↵Frederik Deweerdt
redisFormatSdsCommandArgv fails
2017-01-30Use cached local variable instead using accessorHyungjin Kim
2017-01-30Consider sub by pattern when clear subscribed flagHyungjin Kim
2016-09-30Counting pending subscribe. Fix #396Hyungjin Kim
2015-10-28fixing typoscharsyam
2015-07-27Prevent crash on pending replies in async codeJan-Erik Rediger
Fixes #335.
2015-04-28Fix memory leak in async spontaneous reply handlingantirez
When an asynchronous hiredis connection subscribes to a Pub/Sub channel and gets an error, and in other related conditions, the function redisProcessCallbacks() enters a code path where the link is disconnected, however the function returns before freeing the allocated reply object. This causes a memory leak. The memory leak was trivial to trigger in Redis Sentinel, which uses hiredis, every time we tried to subscribe to an instance that required a password, in case the Sentinel was configured either with the wrong password or without password at all. In this case, the -AUTH error caused the leaking code path to be executed.
2015-01-05Fix redisAppendCommand error resultMatt Stancliff
Previously, redisvAppendCommand() would return OOM even with formatting errors. Now we use OTHER with an error string telling the user the error was formatting related, not memory related. This also fixes a potentially worse bug where were would pass error result of -1 as an actual length to another function taking an unsigned length, which would result in crash/overallocation/errors. Now for that case, we just return an error immediately and stop processing the command. Fixes #177
2015-01-05Fix clang analyzer warningMatt Stancliff
redisAsyncInitialize() can return NULL, but then we pass the return value from redisAsyncInitialize() into something dereferencing the return value, which can cause crashies.
2015-01-05Add support for SO_REUSEADDRmike
[This introduces some new API functions.] * Adds new flag to the connection context indicating SO_REUSEADDR should be set. * Adds max number of retries constant for when connect() hits EADDRNOTAVAIL. * Adds new function, redisAsyncConnectBindWithReuse(), letting clients enable this functionality. [Removed trailing whitespace in new header lines.] Closes #264
2015-01-05Improve redisAppendCommandArgv performancemichael-grunder
OK, perhaps the second time is a charm. I forgot that I had hiredis forked from a long time ago, so the initial pull request was hosed. :) * Pulled in sdscatfmt() from Redis, and modified it to accept a size_t (%T) style format specifier. * Pulled in sdsll2str() and sdsull2str() from Redis (needed by sdscatfmt). * Added a new method, redisFormatSdsCommandArgv() which takes and sds* as the target, rather than char* (and uses sdscatfmt instead of sprintf for the construction). I get roughly the following improvement: Old: 1.044806 New: 0.481620 The benchmark code itself can be found here: https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81 Closes #260
2015-01-05Use stricter function argument typesHang Su
'const' where we can. Closes #268
2015-01-05Free string if it is unusedJan-Erik Rediger
If the string is already in the dict, we need to free this. Original fix by @tt33415366. Fixes #256 Closes #286
2014-04-09Fix const correctnessPieter Noordhuis
2014-04-08Add ability to bind source address on connectMatt Stancliff
Some environments require binding to specific source addresses instead of letting the system determine which IP a connection should originate from. Closes #233
2014-04-08Fix potential undefined struct readMatt Stancliff
All the assignments to cb are inside conditionals, so it's vaguely possible it never gets initialized before we try to read from it with (cb.fn == NULL). Condition discovered with scan-build. Closes #229
2014-04-08Remove possiblity of multiple close on same fdMatt Stancliff
With all the async connects and disconnects and error handling going on in hiredis, we need to centralize how we close our fd and set it so it doesn't get re-closed. Prior to this commit, sometimes we'd close(fd), run an async error handler, then call close(fd) again. To stop multiple closes, we now set fd to -1 after we free it, but that requires not passing fd as an independent argument to functions. This commit moves all fd usage to c->fd. Since the context has a fd field and all functions receive the context, it makes more sense to use the fd inside of c instead of passing along fd as an independent argument. Also, by only using c->fd, we can set c->fd after we close it to signify we shouldn't re-close the same fd again. This does change one semi-public interface function redisCheckSocketError() to only take (context) instead of (context, fd). A search on github returned zero occasions of people using redisCheckSocketError() outside of net.{c,h} in hiredis itself. Commit inspired by the bug report at: https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY Thanks go out to Thijs for trying high-frequency reconnects on a host that isn't there. Closes #230
2014-01-15async.c: avoid a NULL deref when redisAsyncInitialize returns NULLCharlie Somerville
2013-07-10Fix const-related compiler errorsPieter Noordhuis
2013-07-10Merge pull request #132 from nwmcsween/constifyPieter Noordhuis
constify: constify some variables / functions
2013-01-22Prevent AsyncConnect from crashing on memory allocation failures.Henri Doreau
2013-01-22Made connect functions return NULL on alloc failures.Henri Doreau
Updated documentation and examples accordingly.
2012-11-12constify: constify some variables / functionsNathan McSween
2012-07-31Spontaneous error reply can always happenPieter Noordhuis
2012-07-11async: support for determining monitor mode, if so, repush replies callback ↵Alex Leverington
in expectation of another reply.
2011-07-10Include stdlib.h in async.c for free(3), realloc(3) and strtol(3) supportR. Tyler Croy