summaryrefslogtreecommitdiff
path: root/async.c
AgeCommit message (Collapse)Author
2015-01-05Fix redisAppendCommand error resultMatt Stancliff
Previously, redisvAppendCommand() would return OOM even with formatting errors. Now we use OTHER with an error string telling the user the error was formatting related, not memory related. This also fixes a potentially worse bug where were would pass error result of -1 as an actual length to another function taking an unsigned length, which would result in crash/overallocation/errors. Now for that case, we just return an error immediately and stop processing the command. Fixes #177
2015-01-05Fix clang analyzer warningMatt Stancliff
redisAsyncInitialize() can return NULL, but then we pass the return value from redisAsyncInitialize() into something dereferencing the return value, which can cause crashies.
2015-01-05Add support for SO_REUSEADDRmike
[This introduces some new API functions.] * Adds new flag to the connection context indicating SO_REUSEADDR should be set. * Adds max number of retries constant for when connect() hits EADDRNOTAVAIL. * Adds new function, redisAsyncConnectBindWithReuse(), letting clients enable this functionality. [Removed trailing whitespace in new header lines.] Closes #264
2015-01-05Improve redisAppendCommandArgv performancemichael-grunder
OK, perhaps the second time is a charm. I forgot that I had hiredis forked from a long time ago, so the initial pull request was hosed. :) * Pulled in sdscatfmt() from Redis, and modified it to accept a size_t (%T) style format specifier. * Pulled in sdsll2str() and sdsull2str() from Redis (needed by sdscatfmt). * Added a new method, redisFormatSdsCommandArgv() which takes and sds* as the target, rather than char* (and uses sdscatfmt instead of sprintf for the construction). I get roughly the following improvement: Old: 1.044806 New: 0.481620 The benchmark code itself can be found here: https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81 Closes #260
2015-01-05Use stricter function argument typesHang Su
'const' where we can. Closes #268
2015-01-05Free string if it is unusedJan-Erik Rediger
If the string is already in the dict, we need to free this. Original fix by @tt33415366. Fixes #256 Closes #286
2014-04-09Fix const correctnessPieter Noordhuis
2014-04-08Add ability to bind source address on connectMatt Stancliff
Some environments require binding to specific source addresses instead of letting the system determine which IP a connection should originate from. Closes #233
2014-04-08Fix potential undefined struct readMatt Stancliff
All the assignments to cb are inside conditionals, so it's vaguely possible it never gets initialized before we try to read from it with (cb.fn == NULL). Condition discovered with scan-build. Closes #229
2014-04-08Remove possiblity of multiple close on same fdMatt Stancliff
With all the async connects and disconnects and error handling going on in hiredis, we need to centralize how we close our fd and set it so it doesn't get re-closed. Prior to this commit, sometimes we'd close(fd), run an async error handler, then call close(fd) again. To stop multiple closes, we now set fd to -1 after we free it, but that requires not passing fd as an independent argument to functions. This commit moves all fd usage to c->fd. Since the context has a fd field and all functions receive the context, it makes more sense to use the fd inside of c instead of passing along fd as an independent argument. Also, by only using c->fd, we can set c->fd after we close it to signify we shouldn't re-close the same fd again. This does change one semi-public interface function redisCheckSocketError() to only take (context) instead of (context, fd). A search on github returned zero occasions of people using redisCheckSocketError() outside of net.{c,h} in hiredis itself. Commit inspired by the bug report at: https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY Thanks go out to Thijs for trying high-frequency reconnects on a host that isn't there. Closes #230
2014-01-15async.c: avoid a NULL deref when redisAsyncInitialize returns NULLCharlie Somerville
2013-07-10Fix const-related compiler errorsPieter Noordhuis
2013-07-10Merge pull request #132 from nwmcsween/constifyPieter Noordhuis
constify: constify some variables / functions
2013-01-22Prevent AsyncConnect from crashing on memory allocation failures.Henri Doreau
2013-01-22Made connect functions return NULL on alloc failures.Henri Doreau
Updated documentation and examples accordingly.
2012-11-12constify: constify some variables / functionsNathan McSween
2012-07-31Spontaneous error reply can always happenPieter Noordhuis
2012-07-11async: support for determining monitor mode, if so, repush replies callback ↵Alex Leverington
in expectation of another reply.
2011-07-10Include stdlib.h in async.c for free(3), realloc(3) and strtol(3) supportR. Tyler Croy
2011-06-27Change prototype of connect callbackPieter Noordhuis
This commit adds a status argument to the connect callback. It will be called in the event of an unsuccessful connection as well, where the status argument is set to REDIS_ERR. It is set to REDIS_OK otherwise.
2011-06-27Use macro's for event loop hooksPieter Noordhuis
2011-06-18Remove private feature macros for Solaris from compiler flagsPieter Noordhuis
2011-05-29Clarify rationale behind issue #43Pieter Noordhuis
2011-05-24Make sure subscribe is still respectedBlake Matheny
2011-05-24Fix the case where an error reply is received before any callbacks are ↵Blake Matheny
registered
2011-04-21Update licensePieter Noordhuis
2011-04-21Let the async API segfault on OOM for nowPieter Noordhuis
2011-04-21Create protocol reader when creating contextPieter Noordhuis
2011-01-14Make dictionary functions static and include the .c filePieter Noordhuis
2011-01-10strcasecmp and strncasecmp are defined in strings.hPierre Riteau
2010-12-31Unsubscribe messages always have 3 elementsPieter Noordhuis
2010-12-31Clean up dictionaries on freePieter Noordhuis
2010-12-31Delegate pub/sub replies to the right callbackPieter Noordhuis
2010-12-31Add callbacks to channel/pattern dictionariesPieter Noordhuis
2010-12-31Add fields for subscribed channel/pattern namesPieter Noordhuis
2010-12-31Change reply processing code to prepare for pub/subPieter Noordhuis
2010-12-31Copy entire callback in one callPieter Noordhuis
2010-12-29Scope event library related data and hooks to a structPieter Noordhuis
2010-12-28Run pending callbacks with a NULL reply on redisAsyncFree()Pieter Noordhuis
2010-12-28Fix the async free() and disconnect() functionsPieter Noordhuis
To make sure that these functions can also be called from functions other than command callbacks, the flag IN_CALLBACK is introduced that holds whether the context is currently executing a callback. If so, redisAsyncFree() and redisAsyncDisconnect() should delegate their task to the reply processor to avoid segfaults.
2010-12-28Only check REDIS_FREEING when a callback was executedPieter Noordhuis
2010-12-28Add function to explicitly free an async contextPieter Noordhuis
2010-12-28Add write event after setting connect callbackPieter Noordhuis
2010-12-16Add myself to license in some filesPieter Noordhuis
2010-12-07Fire onConnect callback on the first write eventPieter Noordhuis
2010-12-01Use extra field for adapter-specific dataPieter Noordhuis
This makes sure that the "data" field on the asynchronous context can be used for user-specific data.
2010-11-15Explicitly initialize struct fields to NULLPieter Noordhuis
2010-11-03Allow to connect using a unix socket from hiredisPieter Noordhuis
2010-11-02Change error reporting to have an explicit typePieter Noordhuis
When there is an I/O error, errno should be used to find out what is wrong. In other cases, errno cannot be used. So, use an explicit type in Hiredis to define the different error scenarios that can occur.
2010-11-01Use existing function to append to the output bufferPieter Noordhuis
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-14 05:28:34 +0000