| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Major fix:
- `make install` now works properly
Minor fix:
- `make test` now works after `make 32bit` on a 64-bit platform
- added more automated travis tests
|
|
Adds travis testing for 32bit builds as well as compile warnings
on 64 bit and 32 bit builds.
|
|
This is the only way to force a 32-bit build of the test binary
|
|
We need to re-gen pkgconf when the version changes, and the version
is kept in hiredis.h, so make pkgconf depend on hiredis.h.
|
|
Adds DESTDIR support
Fixes INSTALL_PKGCONF_PATH
Properly copies {read,shs}.h now during make install
Closes #297
|
|
|
|
|
|
|
|
|
|
This replaces the old intlen() implementation with a slightly
faster way of counting digits.
Implementation taken from the same place where digits10() in
redis/src/util.c came from.
The old 'intlen' allowed negative inputs, but no usage in hiredis
was passing negative numbers, so that ability is removed. Also,
the new implementation can count higher (uint64_t) instead of
limited to just int as before.
Fixes #295 by replacing implementation
|
|
Suggested at
https://github.com/redis/hiredis/issues/294#issuecomment-69153074
This change also makes the test stop hanging for 10 to 30 seconds
waiting for the resolver to timeout. Now the resolver immediately
sees the hostname is bad and returns error without waiting for timeout.
|
|
Fixes #294
|
|
glibc 2.20 requires _DEFAULT_SOURCE and doesn't like _BSD_SOURCE alone
Also see:
- https://github.com/antirez/redis/pull/2189
- https://sourceware.org/glibc/wiki/Release/2.20#Deprecation_of__BSD_SOURCE_and__SVID_SOURCE_feature_macros
Thanks to badboy for pointing out the problem at
https://github.com/redis/hiredis/issues/288#issuecomment-68849454
|
|
|
|
|
|
|
|
The pkgconf source is localized to the Makefile, so we're not dropping
an unnecessary "hiredis.pc.in" in the source directory.
Closes #129
Closes #136
|
|
The strerror_r API has two flavors depending on system options.
The bad flavor uses a static buffer for returning results, so if
you save the pointer from strerror_r, the string you're referencing
becomes useless if anybody else calls strerror_r again
The good flavor does what you expect: it writes the error to your buffer.
This commit uses strerror_r directly if it's a good version or copies
the static buffer into our private buffer if it's a bad version.
Thanks to gemorin for explaining the problem and drafting a fix.
Fixes #239
|
|
Makes hiredis reading functions easier to include in external projects
[fixed all merge conflicts against current version]
Closes #249
|
|
These should really just be macros to shut up our type system.
|
|
Previously, redisvAppendCommand() would return OOM even with formatting
errors. Now we use OTHER with an error string telling the user the
error was formatting related, not memory related.
This also fixes a potentially worse bug where were would pass error result
of -1 as an actual length to another function taking an unsigned length,
which would result in crash/overallocation/errors. Now for that case,
we just return an error immediately and stop processing the command.
Fixes #177
|
|
[Cleaned up Makefile and header includes. Didn't change crazy
coding style because it's the convention for GLib systems.]
Closes #83
Closes #71
|
|
If realloc fails, the curargv will be NULL.
Closes #253
|
|
Check whether the obuf or reader is empty: if one of the items is empty,
free the redisContext.
|
|
Flags can occur in any order in format string, so we can't assume any order.
In original code, the redisvFormatCommand can process " %#+d" correctly,
but can't process "%+#d".
Closes #257
|
|
External callers may not know about sdsfree, so let's
give them an easy way to know how to free their sds result.
|
|
[Cleaned up:
- name of function: freeRedis... -> redisFree...
- return value of function (free doesn't return anything)
- parameter type for function.
- we don't need to free a char**, the char** is just
for returning from the assignment functoin.]
Closes #250
|
|
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
[Instead of checking for "not solaris" we feature detect
for availability of what we want, then remove the system
that advertises compatability but doesn't actually provide it
(given our assumptions about what we're guarding).]
Closes #254
|
|
redisAsyncInitialize() can return NULL, but then we pass
the return value from redisAsyncInitialize() into something
dereferencing the return value, which can cause crashies.
|
|
[This introduces some new API functions.]
* Adds new flag to the connection context indicating SO_REUSEADDR
should be set.
* Adds max number of retries constant for when connect() hits
EADDRNOTAVAIL.
* Adds new function, redisAsyncConnectBindWithReuse(), letting
clients enable this functionality.
[Removed trailing whitespace in new header lines.]
Closes #264
|
|
[It doesn't _actually_ matter, but technically
the order argument is: (number of items, size of items)]
Closes #279
|
|
This:
- Removes misplaced libuv function prototype
- Includes stdlib for free()
Closes #251
|
|
OK, perhaps the second time is a charm. I forgot that I had
hiredis forked from a long time ago, so the initial pull
request was hosed. :)
* Pulled in sdscatfmt() from Redis, and modified it to accept a
size_t (%T) style format specifier.
* Pulled in sdsll2str() and sdsull2str() from Redis (needed by
sdscatfmt).
* Added a new method, redisFormatSdsCommandArgv() which takes
and sds* as the target, rather than char* (and uses sdscatfmt
instead of sprintf for the construction).
I get roughly the following improvement:
Old: 1.044806
New: 0.481620
The benchmark code itself can be found here:
https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81
Closes #260
|
|
'const' where we can.
Closes #268
|
|
Closes #267
|
|
"sdscatpritf" -> "sdscatprintf"
Example used sdsempty("text") but should say sdsnew("text")
Closes #282
|
|
Closes #285
|
|
If the string is already in the dict, we need to free this.
Original fix by @tt33415366.
Fixes #256
Closes #286
|
|
Closes #293
|
|
Fix getaddrinfo() memory leak
|
|
See antirez/redis#2012 for the leak causing unbounded memory growth.
|
|
Less surprising behaviour in redisFree() and freeReplyObject()
|
|
Test that redisFree() and freeReplyObject() do not crash when NULL is
passed in.
|
|
Make redisFree() and freeReplyObject() less surprising by behaving just
like free(). That is, don't crash when passing in NULL.
|
|
Closes #219.
|
|
|
|
|
|
Next version of hiredis
|
|
Solaris doesn't define the TCP options we try to set. Let's
ignore those under Solaris.
Closes #207
|
