diff options
| author | not-a-robot <not-a-robot@rediger.net> | 2016-04-20 17:42:04 +0200 |
|---|---|---|
| committer | not-a-robot <not-a-robot@rediger.net> | 2016-04-20 17:42:04 +0200 |
| commit | a91afd746b5ea8f00147d8418c716a482f725173 (patch) | |
| tree | 2c6a5d68b65564c701dc44830fce594553c5882f /adapters | |
| parent | d3c7df33a1e278c6f0ae86506e0cbe5de35e36e3 (diff) | |
| parent | d4b715f0aa97bae7bf2f6ebfe4837f39c0451e84 (diff) | |
Auto merge of #379 - thomaslee:tom_test_race, r=badboy
Fix potential race in 'invalid timeout' tests
It's possible for the call to connect() to succeed on the very first try, in which case the logic for checking for invalid timeout fields is never executed. When this happens, the tests fail because they expect a REDIS_ERR_IO but no such failure has occurred.
Tests aside, this is a potential source of irritating and hard-to-find intermittent bugs.
This patch forces the validation to occur early so that we get predictable behavior whenever an invalid timeout is specified.
Diffstat (limited to 'adapters')
0 files changed, 0 insertions, 0 deletions