diff options
| author | michael-grunder <michael.grunder@gmail.com> | 2022-05-04 13:13:54 -0700 |
|---|---|---|
| committer | michael-grunder <michael.grunder@gmail.com> | 2022-06-26 12:03:50 -0700 |
| commit | f4b6ed28989ba0f6c59c64d015a8b0c830b3f1ca (patch) | |
| tree | 72ed376154e65ec4e8adec42ca18be52448acc13 | |
| parent | 95a0c1283a7277f684388edcbdf5b73d0d76104f (diff) | |
| download | hiredict-f4b6ed28989ba0f6c59c64d015a8b0c830b3f1ca.tar.xz | |
Fix tests so they work for Redis 7.0
* Redis >= 7.0.0 disables the `DEBUG` command by default, which we need
for our unit tests.
* Downgrade to Redis 6.2.x in macOS temporarily
There is a macOS specific TLS error on large payloads when running
against 7.x.x so temporarily run our tests against 6.2, while we
investigate the root cause.
| -rw-r--r-- | .github/workflows/build.yml | 3 | ||||
| -rwxr-xr-x | test.sh | 9 |
2 files changed, 11 insertions, 1 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a071628..7859ff4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -152,7 +152,8 @@ jobs: - name: Install dependencies run: | - brew install openssl redis + brew install openssl redis@6.2 + brew link redis@6.2 --force - name: Build hiredis run: USE_SSL=1 make @@ -5,9 +5,16 @@ REDIS_PORT=${REDIS_PORT:-56379} REDIS_SSL_PORT=${REDIS_SSL_PORT:-56443} TEST_SSL=${TEST_SSL:-0} SKIPS_AS_FAILS=${SKIPS_AS_FAILS-:0} +ENABLE_DEBUG_CMD= SSL_TEST_ARGS= SKIPS_ARG= +# We need to enable the DEBUG command for redis-server >= 7.0.0 +REDIS_MAJOR_VERSION="$(redis-server --version|awk -F'[^0-9]+' '{ print $2 }')" +if [ "$REDIS_MAJOR_VERSION" -gt "6" ]; then + ENABLE_DEBUG_CMD="enable-debug-command local" +fi + tmpdir=$(mktemp -d) PID_FILE=${tmpdir}/hiredis-test-redis.pid SOCK_FILE=${tmpdir}/hiredis-test-redis.sock @@ -49,8 +56,10 @@ cleanup() { } trap cleanup INT TERM EXIT + cat > ${tmpdir}/redis.conf <<EOF daemonize yes +${ENABLE_DEBUG_CMD} pidfile ${PID_FILE} port ${REDIS_PORT} bind 127.0.0.1 |