summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMuhammad Zahalqa <m@tryfinally.com>2020-05-20 19:35:15 +0300
committerGitHub <noreply@github.com>2020-05-20 09:35:15 -0700
commitc8999c66024b0de347adecb774d14963c08a66db (patch)
treec7e27c390df051375ff7e1fd1c4b297b3b480856
parent5c9f49e2123c5df7148939a70b80cd72e4e59646 (diff)
Use standrad isxdigit instead of custom helper function. (#814)
Standard function available and on most platforms uses a lookup table and not a check with 3 ranges.
-rw-r--r--sds.c11
1 files changed, 2 insertions, 9 deletions
diff --git a/sds.c b/sds.c
index 6cf7584..e8b996a 100644
--- a/sds.c
+++ b/sds.c
@@ -889,13 +889,6 @@ sds sdscatrepr(sds s, const char *p, size_t len) {
return sdscatlen(s,"\"",1);
}
-/* Helper function for sdssplitargs() that returns non zero if 'c'
- * is a valid hex digit. */
-int is_hex_digit(char c) {
- return (c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') ||
- (c >= 'A' && c <= 'F');
-}
-
/* Helper function for sdssplitargs() that converts a hex digit into an
* integer from 0 to 15 */
int hex_digit_to_int(char c) {
@@ -958,8 +951,8 @@ sds *sdssplitargs(const char *line, int *argc) {
while(!done) {
if (inq) {
if (*p == '\\' && *(p+1) == 'x' &&
- is_hex_digit(*(p+2)) &&
- is_hex_digit(*(p+3)))
+ isxdigit(*(p+2)) &&
+ isxdigit(*(p+3)))
{
unsigned char byte;