diff options
| author | Bjorn Svensson <bjorn.a.svensson@est.tech> | 2021-11-25 08:09:23 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-24 23:09:23 -0800 |
| commit | b5716ee82926316f7764b834eec636f5652d5600 (patch) | |
| tree | 0b7fe7ebeb8f10ece5ca29bafe7b6ac8249143a4 /.github | |
| parent | 1aed21a8c50fe075e8abce9db30c3860673f0fc7 (diff) | |
Valgrind returns error exit code when errors found (#1011)
By default Valgrind will return the exit code from the tested process.
Since our test can return 0 (ALL TESTS PASS) even when a leak was
found we need to tell Valgrind to return an error code.
This will fail the CI job when issues are found.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/build.yml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c43beb6..e4dde05 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: # - name: Run tests under valgrind # env: # SKIPS_AS_FAILS: 1 - # TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + # TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full # run: $GITHUB_WORKSPACE/test.sh centos7: @@ -75,7 +75,7 @@ jobs: env: SKIPS_AS_FAILS: 1 TEST_SSL: 1 - TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full run: $GITHUB_WORKSPACE/test.sh centos8: @@ -115,7 +115,7 @@ jobs: env: SKIPS_AS_FAILS: 1 TEST_SSL: 1 - TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full run: $GITHUB_WORKSPACE/test.sh macos: |