From ed2b1d5c610f0ff2d49780f69b6343d22f878a63 Mon Sep 17 00:00:00 2001 From: Ori Bernstein Date: Sat, 23 Jan 2021 18:02:46 -0800 Subject: upas/fs: fix swapped argument, dead code With ntlm auth, we were trying to set 0 bytes of the auth struct to its size. The args were clearly swapped. Fix it. While we're here, remove some dead code. --- sys/src/cmd/upas/fs/imap.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/sys/src/cmd/upas/fs/imap.c b/sys/src/cmd/upas/fs/imap.c index 85d6d810f..7bcc84477 100644 --- a/sys/src/cmd/upas/fs/imap.c +++ b/sys/src/cmd/upas/fs/imap.c @@ -687,8 +687,7 @@ imap4ntlm(Imap *imap) return "auth_respond failed"; /* prepare NtLmAuthenticate blob */ - - memset(buf, sizeof buf, 0); + memset(buf, 0, sizeof(buf)); p = buf; ep = p + 8 + 6*8 + 2*4; q = ep; @@ -852,14 +851,6 @@ imap4dial(Imap *imap) return nil; } -static void -imap4hangup(Imap *imap) -{ - imap4cmd(imap, "logout"); - imap4resp(imap); - imap4disconnect(imap); -} - /* gmail lies about message sizes */ static ulong gmaildiscount(Message *m, uvlong o, ulong l) -- cgit v1.2.3