From cda46731d8166e5b113a8acdf90479a03bb6a3a8 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Tue, 9 Jun 2015 03:33:37 +0200 Subject: devsegment: fix parsecmd() memory leak --- sys/src/9/port/devsegment.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/src/9/port/devsegment.c b/sys/src/9/port/devsegment.c index 07b0fca9c..384d54aa6 100644 --- a/sys/src/9/port/devsegment.c +++ b/sys/src/9/port/devsegment.c @@ -315,6 +315,10 @@ segmentwrite(Chan *c, void *a, long n, vlong voff) switch(TYPE(c)){ case Qctl: cb = parsecmd(a, n); + if(waserror()){ + free(cb); + nexterror(); + } if(strcmp(cb->f[0], "va") == 0){ if(g->s != nil) error("already has a virtual address"); @@ -335,6 +339,8 @@ segmentwrite(Chan *c, void *a, long n, vlong voff) g->s = newseg(SG_SHARED, va, len); } else error(Ebadctl); + free(cb); + poperror(); break; case Qdata: return segio(g, g->s, a, n, voff, 0); -- cgit v1.2.3