From bdcef9d6928f5bdc214567937b1d219774f48b12 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Sat, 29 Sep 2018 13:58:08 +0200 Subject: 5i ki qi vi: avoid buffer overflow in command read loop --- sys/src/cmd/5i/cmd.c | 2 +- sys/src/cmd/ki/cmd.c | 2 +- sys/src/cmd/qi/cmd.c | 2 +- sys/src/cmd/vi/cmd.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/src/cmd/5i/cmd.c b/sys/src/cmd/5i/cmd.c index c27e5adf5..e1871c017 100644 --- a/sys/src/cmd/5i/cmd.c +++ b/sys/src/cmd/5i/cmd.c @@ -571,7 +571,7 @@ cmd(void) Bflush(bioout); p = buf; n = 0; - for(;;) { + while(n < sizeof(buf)) { i = Bgetc(bin); if(i < 0) exits(0); diff --git a/sys/src/cmd/ki/cmd.c b/sys/src/cmd/ki/cmd.c index 095ae0271..5de0b7253 100644 --- a/sys/src/cmd/ki/cmd.c +++ b/sys/src/cmd/ki/cmd.c @@ -568,7 +568,7 @@ cmd(void) Bflush(bioout); p = buf; n = 0; - for(;;) { + while(n < sizeof(buf)) { i = Bgetc(bin); if(i < 0) exits(0); diff --git a/sys/src/cmd/qi/cmd.c b/sys/src/cmd/qi/cmd.c index 02fc422e7..a976bef51 100644 --- a/sys/src/cmd/qi/cmd.c +++ b/sys/src/cmd/qi/cmd.c @@ -580,7 +580,7 @@ cmd(void) Bflush(bioout); p = buf; n = 0; - for(;;) { + while(n < sizeof(buf)) { i = Bgetc(bin); if(i < 0) exits(0); diff --git a/sys/src/cmd/vi/cmd.c b/sys/src/cmd/vi/cmd.c index f54fe3763..09931ce0c 100644 --- a/sys/src/cmd/vi/cmd.c +++ b/sys/src/cmd/vi/cmd.c @@ -585,7 +585,7 @@ cmd(void) Bflush(bioout); p = buf; n = 0; - for(;;) { + while(n < sizeof(buf)) { i = Bgetc(bin); if(i < 0) exits(0); -- cgit v1.2.3