From 4ae38efc1c28c968d2c5e26d305d917dd25b6594 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Tue, 4 Dec 2012 06:06:28 +0100 Subject: ape/mv: check if from path fits and error if too long --- sys/src/ape/cmd/mv.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/src/ape/cmd/mv.c b/sys/src/ape/cmd/mv.c index 14423c149..4764e34f5 100644 --- a/sys/src/ape/cmd/mv.c +++ b/sys/src/ape/cmd/mv.c @@ -85,7 +85,13 @@ mv1(char *from, Dir *dirb, char *todir, char *toelem) char *fromdir, *fromelem; Dir *dirt, null; - strncpy(fromname, from, sizeof fromname); + i = strlen(from); + if(i >= sizeof(fromname)){ + fprint(2, "mv: path too big (max %d): %s\n", + sizeof(fromname), from); + return -1; + } + memmove(fromname, from, i+1); split(from, &fromdir, &fromelem); if(toelem == 0) toelem = fromelem; -- cgit v1.2.3