From 1e3dd86128928c8b2c4a4bced4398139eadfa4f0 Mon Sep 17 00:00:00 2001 From: Ori Bernstein Date: Tue, 17 Nov 2020 18:37:38 -0800 Subject: upas/*: cleanup mkfiles (thanks amavect) Changeset 50ad211fb12f broke the libcommon rule in mkupas. Deleting the 'mk clean' in the recipe fixes this. Cleanup includes deleting UPDATE vars from all mkfiles, reorganization of vars in TARG,LIB,OFILE,HFILE order, and deletion of extra vars used for UPDATE. --- sys/src/cmd/upas/Mail/mkfile | 19 ++++--------- sys/src/cmd/upas/alias/mkfile | 18 ++++-------- sys/src/cmd/upas/bayes/mkfile | 7 +---- sys/src/cmd/upas/binscripts/mkfile | 9 ++---- sys/src/cmd/upas/binscripts/mkfile.rc | 18 +----------- sys/src/cmd/upas/common/mkfile | 9 ++---- sys/src/cmd/upas/filterkit/mkfile | 10 +------ sys/src/cmd/upas/fs/mkfile | 18 ++++-------- sys/src/cmd/upas/imap4d/mkfile | 15 ++++------ sys/src/cmd/upas/marshal/mkfile | 14 ++-------- sys/src/cmd/upas/mkfile | 52 ++--------------------------------- sys/src/cmd/upas/mkupas | 2 +- sys/src/cmd/upas/ml/dat.h | 2 +- sys/src/cmd/upas/ml/mkfile | 26 ++++++------------ sys/src/cmd/upas/ned/mkfile | 15 ++-------- sys/src/cmd/upas/pop3/mkfile | 9 +----- sys/src/cmd/upas/q/mkfile | 16 ++++------- sys/src/cmd/upas/qfrom/mkfile | 10 ++----- sys/src/cmd/upas/scanmail/mkfile | 23 ++++++---------- sys/src/cmd/upas/send/message.c | 2 +- sys/src/cmd/upas/send/mkfile | 33 ++++++++-------------- sys/src/cmd/upas/smtp/mkfile | 42 +++++++++------------------- sys/src/cmd/upas/smtp/smtpd.c | 2 +- sys/src/cmd/upas/unesc/mkfile | 7 +---- sys/src/cmd/upas/vf/mkfile | 17 ++++-------- 25 files changed, 97 insertions(+), 298 deletions(-) diff --git a/sys/src/cmd/upas/Mail/mkfile b/sys/src/cmd/upas/Mail/mkfile index 260281de8..0055f3dee 100644 --- a/sys/src/cmd/upas/Mail/mkfile +++ b/sys/src/cmd/upas/Mail/mkfile @@ -3,24 +3,18 @@ TARG=Mail OFILES=\ - html.$O\ - mail.$O\ - mesg.$O\ - reply.$O\ - util.$O\ - win.$O + html.$O\ + mail.$O\ + mesg.$O\ + reply.$O\ + util.$O\ + win.$O\ HFILES=dat.h -LIB= # BIN=/acme/bin/$objtype BIN=$ABIN -UPDATE=\ - mkfile\ - $HFILES\ - ${OFILES:%.$O=%.c}\ - syms $CC -aa mesg.c reply.c util.c win.c >>syms - diff --git a/sys/src/cmd/upas/alias/mkfile b/sys/src/cmd/upas/alias/mkfile index 9eb3f37f0..900fa12cd 100644 --- a/sys/src/cmd/upas/alias/mkfile +++ b/sys/src/cmd/upas/alias/mkfile @@ -2,19 +2,11 @@ <../mkupas TARG=aliasmail - -OFILES=aliasmail.$O\ - -LIB=../common/libcommon.a$O\ - -HFILES=../common/common.h\ - ../common/sys.h\ - - -UPDATE=\ - mkfile\ - $HFILES\ - ${OFILES:%.$O=%.c}\ +LIB=../common/libcommon.a$O +OFILES=aliasmail.$O +HFILES=\ + ../common/common.h\ + ../common/sys.h\ a$O diff --git a/sys/src/cmd/upas/imap4d/mkfile b/sys/src/cmd/upas/imap4d/mkfile index c751963fa..4ae435944 100644 --- a/sys/src/cmd/upas/imap4d/mkfile +++ b/sys/src/cmd/upas/imap4d/mkfile @@ -1,4 +1,7 @@ >>>>>>>>>' `{pwd} '<<<<<<<<<<<' - mk $MKFLAGS 'UPDATEFLAGS='$"UPDATEFLAGS update - } diff --git a/sys/src/cmd/upas/mkupas b/sys/src/cmd/upas/mkupas index 66790ac44..622d700cc 100644 --- a/sys/src/cmd/upas/mkupas +++ b/sys/src/cmd/upas/mkupas @@ -2,4 +2,4 @@ BIN=/$objtype/bin/upas ABIN=/acme/bin/$objtype ../common/libcommon.a$O: - cd ../common; mk; mk clean + cd ../common; mk diff --git a/sys/src/cmd/upas/ml/dat.h b/sys/src/cmd/upas/ml/dat.h index 3527af508..5d23bae8f 100644 --- a/sys/src/cmd/upas/ml/dat.h +++ b/sys/src/cmd/upas/ml/dat.h @@ -1,6 +1,6 @@ #include "../smtp/smtp.h" -#include "../smtp/y.tab.h" +#include "../smtp/rfc822.tab.h" typedef struct Addr Addr; struct Addr diff --git a/sys/src/cmd/upas/ml/mkfile b/sys/src/cmd/upas/ml/mkfile index 7a6350e16..c87953545 100644 --- a/sys/src/cmd/upas/ml/mkfile +++ b/sys/src/cmd/upas/ml/mkfile @@ -1,30 +1,20 @@ #include "../smtp/smtp.h" -#include "../smtp/y.tab.h" +#include "../smtp/rfc822.tab.h" enum{ VMLIMIT = 64*1024, diff --git a/sys/src/cmd/upas/send/mkfile b/sys/src/cmd/upas/send/mkfile index 549d234f0..699374dd8 100644 --- a/sys/src/cmd/upas/send/mkfile +++ b/sys/src/cmd/upas/send/mkfile @@ -1,16 +1,17 @@ $target rm xxx -rfc822.tab.c: rfc822.y - yacc -d -o $target rfc822.y +rfc822.tab.c rfc822.tab.h:D: rfc822.y + yacc -d -s rfc822 rfc822.y $O.parsetest: rfc822.tab.$O parsetest.$O: rfc822.tab.$O - -clean:V: - rm -f *.[$OS] [$OS].^($TARG $TEST) smtpd.tab.c rfc822.tab.c y.tab.? y.debug $TARG - -../common/libcommon.a$O: - cd ../common && mk - -<../mkupas diff --git a/sys/src/cmd/upas/smtp/smtpd.c b/sys/src/cmd/upas/smtp/smtpd.c index 0c974a835..907302876 100644 --- a/sys/src/cmd/upas/smtp/smtpd.c +++ b/sys/src/cmd/upas/smtp/smtpd.c @@ -7,7 +7,7 @@ #include #include #include -#include "../smtp/y.tab.h" +#include "rfc822.tab.h" char *me; char *him=""; diff --git a/sys/src/cmd/upas/unesc/mkfile b/sys/src/cmd/upas/unesc/mkfile index e02edc484..c5be446cf 100644 --- a/sys/src/cmd/upas/unesc/mkfile +++ b/sys/src/cmd/upas/unesc/mkfile @@ -2,11 +2,6 @@ <../mkupas TARG=unesc -OFILES=unesc.$O\ - -UPDATE=\ - mkfile\ - $HFILES\ - ${OFILES:%.$O=%.c}\ +OFILES=unesc.$O