From 038da00e799b4bf3af824075a260083c56392964 Mon Sep 17 00:00:00 2001 From: Herman Semenov Date: Tue, 6 Sep 2022 13:21:09 +0300 Subject: Code optimizations / refactor (#12704) Co-authored-by: SmallJoker Co-authored-by: sfan5 --- src/network/clientpackethandler.cpp | 2 +- src/network/connection.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/network') diff --git a/src/network/clientpackethandler.cpp b/src/network/clientpackethandler.cpp index 25c1d2690..2933bb9f0 100644 --- a/src/network/clientpackethandler.cpp +++ b/src/network/clientpackethandler.cpp @@ -152,7 +152,7 @@ void Client::handleCommand_AuthAccept(NetworkPacket* pkt) language code (e.g. "de" for German). */ std::string lang = gettext("LANG_CODE"); if (lang == "LANG_CODE") - lang = ""; + lang.clear(); NetworkPacket resp_pkt(TOSERVER_INIT2, sizeof(u16) + lang.size()); resp_pkt << lang; diff --git a/src/network/connection.cpp b/src/network/connection.cpp index 6fb676f25..54ef5390c 100644 --- a/src/network/connection.cpp +++ b/src/network/connection.cpp @@ -64,7 +64,7 @@ BufferedPacketPtr makePacket(Address &address, const SharedBuffer &data, { u32 packet_size = data.getSize() + BASE_HEADER_SIZE; - BufferedPacketPtr p(new BufferedPacket(packet_size)); + auto p = std::make_shared(packet_size); p->address = address; writeU32(&p->data[0], protocol_id); @@ -492,10 +492,10 @@ SharedBuffer IncomingSplitBuffer::insert(BufferedPacketPtr &p_ptr, bool reli void IncomingSplitBuffer::removeUnreliableTimedOuts(float dtime, float timeout) { - std::deque remove_queue; + std::vector remove_queue; { MutexAutoLock listlock(m_map_mutex); - for (auto &i : m_buf) { + for (const auto &i : m_buf) { IncomingSplitPacket *p = i.second; // Reliable ones are not removed by timeout if (p->reliable) -- cgit v1.2.3