From 6fd8a27c91b09f51693243586af3615f962d1730 Mon Sep 17 00:00:00 2001 From: Loïc Blot Date: Mon, 28 Aug 2017 17:12:30 +0200 Subject: Pass SharedBuffer as value to increment reference count This should fix #6332 Refcount is not increased due to reference, it can make this refcount incorrect in a multithread context --- src/network/connectionthreads.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/network/connectionthreads.h') diff --git a/src/network/connectionthreads.h b/src/network/connectionthreads.h index 11bec0c6c..c2314f87f 100644 --- a/src/network/connectionthreads.h +++ b/src/network/connectionthreads.h @@ -118,26 +118,26 @@ private: channelnum: channel on which the packet was sent reliable: true if recursing into a reliable packet */ - SharedBuffer processPacket(Channel *channel, SharedBuffer &packetdata, + SharedBuffer processPacket(Channel *channel, SharedBuffer packetdata, u16 peer_id, u8 channelnum, bool reliable); SharedBuffer handlePacketType_Control(Channel *channel, - SharedBuffer &packetdata, Peer *peer, u8 channelnum, + SharedBuffer packetdata, Peer *peer, u8 channelnum, bool reliable); SharedBuffer handlePacketType_Original(Channel *channel, - SharedBuffer &packetdata, Peer *peer, u8 channelnum, + SharedBuffer packetdata, Peer *peer, u8 channelnum, bool reliable); SharedBuffer handlePacketType_Split(Channel *channel, - SharedBuffer &packetdata, Peer *peer, u8 channelnum, + SharedBuffer packetdata, Peer *peer, u8 channelnum, bool reliable); SharedBuffer handlePacketType_Reliable(Channel *channel, - SharedBuffer &packetdata, Peer *peer, u8 channelnum, + SharedBuffer packetdata, Peer *peer, u8 channelnum, bool reliable); struct PacketTypeHandler { SharedBuffer (ConnectionReceiveThread::*handler)(Channel *channel, - SharedBuffer &packet, Peer *peer, u8 channelnum, + SharedBuffer packet, Peer *peer, u8 channelnum, bool reliable); }; -- cgit v1.2.3