From eabf04bd34b840ee3359609fc977cf4795b33a3a Mon Sep 17 00:00:00 2001 From: Loic Blot Date: Sun, 3 Sep 2017 19:01:53 +0200 Subject: Network part requires SharedBuffers to be pass as value This can trigger unreproductible crashes due to concurrency problem on SharedBuffers This fixes #6354 --- src/network/connectionthreads.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/network/connectionthreads.cpp') diff --git a/src/network/connectionthreads.cpp b/src/network/connectionthreads.cpp index 63c1855c5..ec09e9d3e 100644 --- a/src/network/connectionthreads.cpp +++ b/src/network/connectionthreads.cpp @@ -330,7 +330,7 @@ void ConnectionSendThread::sendAsPacketReliable(BufferedPacket &p, Channel *chan } bool ConnectionSendThread::rawSendAsPacket(u16 peer_id, u8 channelnum, - const SharedBuffer &data, bool reliable) + SharedBuffer data, bool reliable) { PeerHelper peer = m_connection->getPeerNoEx(peer_id); if (!peer) { -- cgit v1.2.3