From 8b26bab37d4cd1cbe63f665ea26edfbb5d5a72e5 Mon Sep 17 00:00:00 2001 From: Jude Melton-Houghton Date: Wed, 23 Nov 2022 17:46:20 -0500 Subject: Remove unnecessary bool return types --- src/database/database-files.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'src/database/database-files.cpp') diff --git a/src/database/database-files.cpp b/src/database/database-files.cpp index e90a50619..5b41f6c19 100644 --- a/src/database/database-files.cpp +++ b/src/database/database-files.cpp @@ -381,34 +381,30 @@ ModStorageDatabaseFiles::ModStorageDatabaseFiles(const std::string &savedir): { } -bool ModStorageDatabaseFiles::getModEntries(const std::string &modname, StringMap *storage) +void ModStorageDatabaseFiles::getModEntries(const std::string &modname, StringMap *storage) { Json::Value *meta = getOrCreateJson(modname); if (!meta) - return false; + return; const Json::Value::Members attr_list = meta->getMemberNames(); for (const auto &it : attr_list) { Json::Value attr_value = (*meta)[it]; (*storage)[it] = attr_value.asString(); } - - return true; } -bool ModStorageDatabaseFiles::getModKeys(const std::string &modname, +void ModStorageDatabaseFiles::getModKeys(const std::string &modname, std::vector *storage) { Json::Value *meta = getOrCreateJson(modname); if (!meta) - return false; + return; std::vector keys = meta->getMemberNames(); storage->reserve(storage->size() + keys.size()); for (std::string &key : keys) storage->push_back(std::move(key)); - - return true; } bool ModStorageDatabaseFiles::getModEntry(const std::string &modname, -- cgit v1.2.3