aboutsummaryrefslogtreecommitdiff
path: root/src/database/database-postgresql.cpp
diff options
context:
space:
mode:
authorLoïc Blot <loic.blot@unix-experience.fr>2019-01-04 10:20:04 +0100
committerLoïc Blot <loic.blot@unix-experience.fr>2019-01-04 10:20:04 +0100
commitc1d7dbfc38e8f48b42d957afad2696a8e56b740b (patch)
tree53db583fc199c9eb096c15e6ffa6c85539a54c0d /src/database/database-postgresql.cpp
parent07177190734b0e5c17be18d0bf5d509c5226af2f (diff)
downloadminetest-c1d7dbfc38e8f48b42d957afad2696a8e56b740b.tar.xz
Fix various player save issues (performance penalty on sql backends + bugs)
* PostgreSQL & SQLite3 doesn't setModified(false) on RemotePlayer, then player is saved on each server save call. This results in heavy useless writes. * PostgreSQL & SQLite3 ack engine meta write whereas db commit hasn't been performed. If commit failed write has failed. We mustn't notify engine write is done. * serializing player meta must not setModified(false) because it didn't ensure write has been done * add RemotePlayer::on_successfull_save callback to do the flag update on a successful save
Diffstat (limited to 'src/database/database-postgresql.cpp')
-rw-r--r--src/database/database-postgresql.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/database/database-postgresql.cpp b/src/database/database-postgresql.cpp
index eec838ef0..f5f8e3adf 100644
--- a/src/database/database-postgresql.cpp
+++ b/src/database/database-postgresql.cpp
@@ -527,8 +527,9 @@ void PlayerDatabasePostgreSQL::savePlayer(RemotePlayer *player)
};
execPrepared("save_player_metadata", 3, meta_values);
}
- sao->getMeta().setModified(false);
endSave();
+
+ player->on_successful_save();
}
bool PlayerDatabasePostgreSQL::loadPlayer(RemotePlayer *player, PlayerSAO *sao)