From ad148587dcf5244c2d2011dba339786c765c54c4 Mon Sep 17 00:00:00 2001 From: Elias Fleckenstein Date: Wed, 4 Nov 2020 16:19:54 +0100 Subject: Make Lint Happy --- src/inventorymanager.cpp | 313 +++++++++++++++++++++++------------------------ 1 file changed, 152 insertions(+), 161 deletions(-) (limited to 'src/inventorymanager.cpp') diff --git a/src/inventorymanager.cpp b/src/inventorymanager.cpp index b6f464901..6b5a79fd9 100644 --- a/src/inventorymanager.cpp +++ b/src/inventorymanager.cpp @@ -29,7 +29,7 @@ with this program; if not, write to the Free Software Foundation, Inc., #include "util/strfnd.h" #include "util/basic_macros.h" -#define PLAYER_TO_SA(p) p->getEnv()->getScriptIface() +#define PLAYER_TO_SA(p) p->getEnv()->getScriptIface() /* InventoryLocation @@ -46,19 +46,19 @@ void InventoryLocation::serialize(std::ostream &os) const { switch (type) { case InventoryLocation::UNDEFINED: - os<<"undefined"; + os << "undefined"; break; case InventoryLocation::CURRENT_PLAYER: - os<<"current_player"; + os << "current_player"; break; case InventoryLocation::PLAYER: - os<<"player:"<getInventory(from_inv); Inventory *inv_to = mgr->getInventory(to_inv); if (!inv_from) { infostream << "IMoveAction::apply(): FAIL: source inventory not found: " - << "from_inv=\""<getSize(); @@ -235,17 +234,17 @@ void IMoveAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGame } if ((u16)to_i > list_to->getSize()) { - infostream << "IMoveAction::apply(): FAIL: destination index out of bounds: " - << "to_i=" << to_i - << ", size=" << list_to->getSize() << std::endl; + infostream << "IMoveAction::apply(): FAIL: destination index out of " + "bounds: " + << "to_i=" << to_i << ", size=" << list_to->getSize() + << std::endl; return; } /* Do not handle rollback if both inventories are that of the same player */ - bool ignore_rollback = ( - from_inv.type == InventoryLocation::PLAYER && - from_inv == to_inv); + bool ignore_rollback = (from_inv.type == InventoryLocation::PLAYER && + from_inv == to_inv); /* Collect information of endpoints @@ -261,25 +260,28 @@ void IMoveAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGame /* Query detached inventories */ // Move occurs in the same detached inventory - if (from_inv.type == InventoryLocation::DETACHED && - from_inv == to_inv) { + if (from_inv.type == InventoryLocation::DETACHED && from_inv == to_inv) { src_can_take_count = PLAYER_TO_SA(player)->detached_inventory_AllowMove( - *this, try_take_count, player); + *this, try_take_count, player); dst_can_put_count = src_can_take_count; } else { // Destination is detached if (to_inv.type == InventoryLocation::DETACHED) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - dst_can_put_count = PLAYER_TO_SA(player)->detached_inventory_AllowPut( - *this, src_item, player); + dst_can_put_count = + PLAYER_TO_SA(player)->detached_inventory_AllowPut( + *this, src_item, player); } // Source is detached if (from_inv.type == InventoryLocation::DETACHED) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - src_can_take_count = PLAYER_TO_SA(player)->detached_inventory_AllowTake( - *this, src_item, player); + src_can_take_count = + PLAYER_TO_SA(player) + ->detached_inventory_AllowTake( + *this, src_item, + player); } } @@ -287,50 +289,54 @@ void IMoveAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGame // Both endpoints are nodemeta // Move occurs in the same nodemeta inventory - if (from_inv.type == InventoryLocation::NODEMETA && - from_inv == to_inv) { + if (from_inv.type == InventoryLocation::NODEMETA && from_inv == to_inv) { src_can_take_count = PLAYER_TO_SA(player)->nodemeta_inventory_AllowMove( - *this, try_take_count, player); + *this, try_take_count, player); dst_can_put_count = src_can_take_count; } else { // Destination is nodemeta if (to_inv.type == InventoryLocation::NODEMETA) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - dst_can_put_count = PLAYER_TO_SA(player)->nodemeta_inventory_AllowPut( - *this, src_item, player); + dst_can_put_count = + PLAYER_TO_SA(player)->nodemeta_inventory_AllowPut( + *this, src_item, player); } // Source is nodemeta if (from_inv.type == InventoryLocation::NODEMETA) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - src_can_take_count = PLAYER_TO_SA(player)->nodemeta_inventory_AllowTake( - *this, src_item, player); + src_can_take_count = + PLAYER_TO_SA(player) + ->nodemeta_inventory_AllowTake( + *this, src_item, + player); } } // Query player inventories // Move occurs in the same player inventory - if (from_inv.type == InventoryLocation::PLAYER && - from_inv == to_inv) { + if (from_inv.type == InventoryLocation::PLAYER && from_inv == to_inv) { src_can_take_count = PLAYER_TO_SA(player)->player_inventory_AllowMove( - *this, try_take_count, player); + *this, try_take_count, player); dst_can_put_count = src_can_take_count; } else { // Destination is a player if (to_inv.type == InventoryLocation::PLAYER) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - dst_can_put_count = PLAYER_TO_SA(player)->player_inventory_AllowPut( - *this, src_item, player); + dst_can_put_count = + PLAYER_TO_SA(player)->player_inventory_AllowPut( + *this, src_item, player); } // Source is a player if (from_inv.type == InventoryLocation::PLAYER) { ItemStack src_item = list_from->getItem(from_i); src_item.count = try_take_count; - src_can_take_count = PLAYER_TO_SA(player)->player_inventory_AllowTake( - *this, src_item, player); + src_can_take_count = + PLAYER_TO_SA(player)->player_inventory_AllowTake( + *this, src_item, player); } } @@ -355,15 +361,13 @@ void IMoveAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGame if (to_inv.type == InventoryLocation::PLAYER) list_to->setModified(); - infostream<<"IMoveAction::apply(): move was completely disallowed:" - <<" count="<getItem(from_i).empty()) { - infostream<<"IDropAction::apply(): FAIL: source item not found: " - <<"from_inv=\""<takeItem(from_i, actually_dropped_count); + ItemStack item2 = list_from->takeItem( + from_i, actually_dropped_count); if (item2.count != actually_dropped_count) - errorstream<<"Could not take dropped count of items"<setInventoryModified(from_inv); } - infostream<<"IDropAction::apply(): dropped " - <<" from inv=\""<getSize() < 1) { infostream << "ICraftAction::apply(): FAIL: craftresult list too short: " - << "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl; + << "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl; return; } @@ -825,7 +816,8 @@ void ICraftAction::apply(InventoryManager *mgr, std::vector temp; // Decrement input and add crafting output getCraftingResult(inv_craft, crafted, temp, true, gamedef); - PLAYER_TO_SA(player)->item_OnCraft(crafted, player, &saved_craft_list, craft_inv); + PLAYER_TO_SA(player)->item_OnCraft( + crafted, player, &saved_craft_list, craft_inv); list_craftresult->addItem(0, crafted); mgr->setInventoryModified(craft_inv); @@ -834,7 +826,8 @@ void ICraftAction::apply(InventoryManager *mgr, for (auto &itemstack : temp) { for (auto &output_replacement : output_replacements) { if (itemstack.name == output_replacement.name) { - itemstack = output_replacement.addItem(itemstack, itemdef); + itemstack = output_replacement.addItem( + itemstack, itemdef); if (itemstack.empty()) continue; } @@ -842,10 +835,8 @@ void ICraftAction::apply(InventoryManager *mgr, output_replacements.push_back(itemstack); } - actionstream << player->getDescription() - << " crafts " - << crafted.getItemString() - << std::endl; + actionstream << player->getDescription() << " crafts " + << crafted.getItemString() << std::endl; // Decrement counter if (count_remaining == 1) @@ -856,7 +847,8 @@ void ICraftAction::apply(InventoryManager *mgr, // Get next crafting result getCraftingResult(inv_craft, crafted, temp, false, gamedef); - PLAYER_TO_SA(player)->item_CraftPredict(crafted, player, list_craft, craft_inv); + PLAYER_TO_SA(player)->item_CraftPredict( + crafted, player, list_craft, craft_inv); found = !crafted.empty(); } @@ -870,20 +862,21 @@ void ICraftAction::apply(InventoryManager *mgr, u16 count = output_replacement.count; do { PLAYER_TO_SA(player)->item_OnDrop(output_replacement, player, - player->getBasePosition()); + player->getBasePosition()); if (count >= output_replacement.count) { - errorstream << "Couldn't drop replacement stack " << - output_replacement.getItemString() << " because drop loop didn't " - "decrease count." << std::endl; + errorstream << "Couldn't drop replacement stack " + << output_replacement.getItemString() + << " because drop loop didn't " + "decrease count." + << std::endl; break; } } while (!output_replacement.empty()); } - infostream<<"ICraftAction::apply(): crafted " - <<" craft_inv=\""< &output_replacements, - bool decrementInput, IGameDef *gamedef) + std::vector &output_replacements, bool decrementInput, + IGameDef *gamedef) { result.clear(); @@ -909,7 +901,7 @@ bool getCraftingResult(Inventory *inv, ItemStack &result, CraftInput ci; ci.method = CRAFT_METHOD_NORMAL; ci.width = clist->getWidth() ? clist->getWidth() : 3; - for (u16 i=0; i < clist->getSize(); i++) + for (u16 i = 0; i < clist->getSize(); i++) ci.items.push_back(clist->getItem(i)); // Find out what is crafted and add it to result item slot @@ -921,11 +913,10 @@ bool getCraftingResult(Inventory *inv, ItemStack &result, if (found && decrementInput) { // CraftInput has been changed, apply changes in clist - for (u16 i=0; i < clist->getSize(); i++) { + for (u16 i = 0; i < clist->getSize(); i++) { clist->changeItem(i, ci.items[i]); } } return found; } - -- cgit v1.2.3