diff options
| author | kwolekr <kwolekr@minetest.net> | 2014-10-28 02:18:48 -0400 |
|---|---|---|
| committer | kwolekr <kwolekr@minetest.net> | 2014-10-28 02:23:45 -0400 |
| commit | 4a3592ff9a10767c2831b569a316560a7d30577d (patch) | |
| tree | ae76ac25059b19935bc35dd69fb740aeccf25bcf /src/nodedef.cpp | |
| parent | bc28ca0636f5bce85683a7114ad99df4e7791847 (diff) | |
| download | dragonfireclient-4a3592ff9a10767c2831b569a316560a7d30577d.tar.xz | |
Add NodeResolver documentation
Set content to fallback on AddNode failure
Consider node list requests with no results as failed
Diffstat (limited to 'src/nodedef.cpp')
| -rw-r--r-- | src/nodedef.cpp | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/src/nodedef.cpp b/src/nodedef.cpp index 3fc9bbc11..820f4eb30 100644 --- a/src/nodedef.cpp +++ b/src/nodedef.cpp @@ -1282,11 +1282,12 @@ int NodeResolver::addNode(std::string n_wanted, std::string n_alt, if (m_ndef->getId(n_wanted, *content)) return NR_STATUS_SUCCESS; - if (n_alt == "") + if (n_alt == "" || !m_ndef->getId(n_alt, *content)) { + *content = c_fallback; return NR_STATUS_FAILURE; + } - return m_ndef->getId(n_alt, *content) ? - NR_STATUS_SUCCESS : NR_STATUS_FAILURE; + return NR_STATUS_SUCCESS; } else { NodeResolveInfo *nfi = new NodeResolveInfo; nfi->n_wanted = n_wanted; @@ -1378,7 +1379,7 @@ int NodeResolver::resolveNodes() "resolve '" << nri->n_wanted; if (nri->n_alt != "") errorstream << "' and '" << nri->n_alt; - errorstream << "' to a content ID" << std::endl; + errorstream << "'" << std::endl; } delete nri; @@ -1399,6 +1400,12 @@ int NodeResolver::resolveNodes() m_ndef->getIds(name, idset); for (it = idset.begin(); it != idset.end(); ++it) output->push_back(*it); + + if (idset.size() == 0) { + num_failed++; + errorstream << "NodeResolver::resolveNodes(): Failed to " + "resolve '" << name << "'" << std::endl; + } } //// Mark node registration as complete so future resolve |