From 0027aae10330a83966a6fbdcce0652138f35e43c Mon Sep 17 00:00:00 2001 From: saschawillems Date: Fri, 29 Dec 2017 19:31:21 +0100 Subject: Proper decoding for msbuild version number readout --- scripts/determine_vs_version.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'scripts/determine_vs_version.py') diff --git a/scripts/determine_vs_version.py b/scripts/determine_vs_version.py index ea2221f9..7982bf71 100755 --- a/scripts/determine_vs_version.py +++ b/scripts/determine_vs_version.py @@ -20,6 +20,7 @@ import sys import os +import subprocess # Following function code snippet was found on StackOverflow (with a change to lower # camel-case on the variable names): @@ -63,7 +64,7 @@ def determine_year(version): # it into a format we can use, which is " ". if __name__ == '__main__': exeName = 'msbuild.exe' - versionCall = exeName + ' /ver' + arguments = '/ver' # Determine if the executable exists in the path, this is critical. # @@ -75,7 +76,8 @@ if __name__ == '__main__': print('00 0000') print('Executable ' + exeName + ' not found in PATH!') else: - sysCallOut = os.popen(versionCall).read() + proc = subprocess.Popen([exeName, arguments], stdout=subprocess.PIPE) + sysCallOut = proc.stdout.readline().decode('iso-8859-1').rstrip() version = None -- cgit v1.2.3