From 78fc9dd3af018d95b63ffb25f4e94cb08e9e6617 Mon Sep 17 00:00:00 2001 From: Courtney Goeltzenleuchter Date: Wed, 10 Feb 2016 15:13:55 -0700 Subject: bug-135: param_checker incorrectly checking optional strings https://gitlab.khronos.org/vulkan/LoaderAndTools/issues/135 --- layers/param_checker.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'layers') diff --git a/layers/param_checker.cpp b/layers/param_checker.cpp index 3cbfd23e..596e609e 100644 --- a/layers/param_checker.cpp +++ b/layers/param_checker.cpp @@ -1829,11 +1829,15 @@ VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance( // support is in place until now, if we survive we can report the issue now. layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); if (pCreateInfo->pApplicationInfo) { - skipCall |= validate_string(my_device_data, "vkCreateInstance()", "VkInstanceCreateInfo->VkApplicationInfo->pApplicationName", - pCreateInfo->pApplicationInfo->pApplicationName); + if (pCreateInfo->pApplicationInfo->pApplicationName) { + skipCall |= validate_string(my_device_data, "vkCreateInstance()", "VkInstanceCreateInfo->VkApplicationInfo->pApplicationName", + pCreateInfo->pApplicationInfo->pApplicationName); + } - skipCall |= validate_string(my_device_data, "vkCreateInstance()", "VkInstanceCreateInfo->VkApplicationInfo->pEngineName", - pCreateInfo->pApplicationInfo->pEngineName); + if (pCreateInfo->pApplicationInfo->pEngineName) { + skipCall |= validate_string(my_device_data, "vkCreateInstance()", "VkInstanceCreateInfo->VkApplicationInfo->pEngineName", + pCreateInfo->pApplicationInfo->pEngineName); + } } return result; -- cgit v1.2.3