From dd8052e42b7f274af26cf80d8d375bde923b44df Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Wed, 25 Nov 2015 08:32:46 +1300 Subject: layers/SC: Delete disabled FS broadcast checking code The support for collecting builtins on an interface is still kept however -- we're likely to want to validate other builtin usage against the pipeline config. --- layers/shader_checker.cpp | 26 -------------------------- 1 file changed, 26 deletions(-) (limited to 'layers/shader_checker.cpp') diff --git a/layers/shader_checker.cpp b/layers/shader_checker.cpp index 2f26cdc1..2697064c 100644 --- a/layers/shader_checker.cpp +++ b/layers/shader_checker.cpp @@ -899,32 +899,6 @@ validate_fs_outputs_against_render_pass(layer_data *my_data, VkDevice dev, shade collect_interface_by_location(my_data, dev, fs, spv::StorageClassOutput, outputs, builtin_outputs); - /* Check for legacy gl_FragColor broadcast: In this case, we should have no user-defined outputs, - * and all color attachment should be UNORM/SNORM/FLOAT. - */ -#if 0 - if (builtin_outputs.find(spv::BuiltInFragColor) != builtin_outputs.end()) { - if (outputs.size()) { - if (log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DEVICE, /*dev*/0, 0, SHADER_CHECKER_FS_MIXED_BROADCAST, "SC", - "Should not have user-defined FS outputs when using broadcast")) { - pass = false; - } - } - - for (unsigned i = 0; i < color_formats.size(); i++) { - unsigned attachmentType = get_format_type(color_formats[i]); - if (attachmentType == FORMAT_TYPE_SINT || attachmentType == FORMAT_TYPE_UINT) { - if (log_msg(my_data->report_data, VK_DBG_REPORT_ERROR_BIT, VK_OBJECT_TYPE_DEVICE, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", - "CB format should not be SINT or UINT when using broadcast")) { - pass = false; - } - } - } - - return pass; - } -#endif - auto it = outputs.begin(); uint32_t attachment = 0; -- cgit v1.2.3