From 1e22669abcb4bb0f950f5166fb368ef7b1517460 Mon Sep 17 00:00:00 2001 From: Courtney Goeltzenleuchter Date: Thu, 10 Sep 2015 17:58:54 -0600 Subject: Bug 12998: change ImageSubresourceRange's aspect to aspectMask --- layers/param_checker.cpp | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) (limited to 'layers/param_checker.cpp') diff --git a/layers/param_checker.cpp b/layers/param_checker.cpp index 9a623160..3c27fd09 100644 --- a/layers/param_checker.cpp +++ b/layers/param_checker.cpp @@ -3859,13 +3859,6 @@ bool PreCreateImageView( "vkCreateImageView parameter, VkChannelSwizzle pCreateInfo->channels.a, is an unrecognized enumerator"); return false; } - if(pCreateInfo->subresourceRange.aspect < VK_IMAGE_ASPECT_BEGIN_RANGE || - pCreateInfo->subresourceRange.aspect > VK_IMAGE_ASPECT_END_RANGE) - { - log_msg(mdd(device), VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, 1, "PARAMCHECK", - "vkCreateImageView parameter, VkImageAspect pCreateInfo->subresourceRange.aspect, is an unrecognized enumerator"); - return false; - } } return true; @@ -6632,13 +6625,7 @@ bool PreCmdClearColorImage( if(pRanges != nullptr) { - if(pRanges->aspect < VK_IMAGE_ASPECT_BEGIN_RANGE || - pRanges->aspect > VK_IMAGE_ASPECT_END_RANGE) - { - log_msg(mdd(cmdBuffer), VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, 1, "PARAMCHECK", - "vkCmdClearColorImage parameter, VkImageAspect pRanges->aspect, is an unrecognized enumerator"); - return false; - } + /* TODO: How should we validate pRanges->aspectMask */ } return true; @@ -6685,13 +6672,11 @@ bool PreCmdClearDepthStencilImage( { if(pRanges != nullptr) { - if(pRanges->aspect < VK_IMAGE_ASPECT_BEGIN_RANGE || - pRanges->aspect > VK_IMAGE_ASPECT_END_RANGE) - { - log_msg(mdd(cmdBuffer), VK_DBG_REPORT_ERROR_BIT, (VkDbgObjectType)0, 0, 0, 1, "PARAMCHECK", - "vkCmdClearDepthStencilImage parameter, VkImageAspect pRanges->aspect, is an unrecognized enumerator"); - return false; - } + /* + * TODO: How do we validation pRanges->aspectMask? + * Allows values are: VK_IMAGE_ASPECT_DEPTH_BIT and + * VK_IMAGE_ASPECT_STENCIL_BIT. + */ } return true; -- cgit v1.2.3