From d3b932c28d1cefac406562adcf7ea5b2f24978f9 Mon Sep 17 00:00:00 2001 From: Mark Lobodzinski Date: Tue, 17 May 2016 08:44:09 -0600 Subject: layers: GH485, Remove redundant format props check With new checks in place for CreateImage, old check in CreateRenderPass is redundant and can be removed. Change-Id: I53e5201f453041b3c8ba17edc193c1f3b142f4cb --- layers/image.cpp | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'layers/image.cpp') diff --git a/layers/image.cpp b/layers/image.cpp index b420cad1..840c543e 100644 --- a/layers/image.cpp +++ b/layers/image.cpp @@ -414,23 +414,6 @@ VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderP VkRenderPass *pRenderPass) { layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); bool skipCall = false; - for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { - if (pCreateInfo->pAttachments[i].format != VK_FORMAT_UNDEFINED) { - VkFormatProperties properties; - get_my_data_ptr(get_dispatch_key(my_data->physicalDevice), layer_data_map) - ->instance_dispatch_table->GetPhysicalDeviceFormatProperties(my_data->physicalDevice, - pCreateInfo->pAttachments[i].format, &properties); - - if ((properties.linearTilingFeatures) == 0 && (properties.optimalTilingFeatures == 0)) { - std::stringstream ss; - ss << "vkCreateRenderPass parameter, VkFormat in pCreateInfo->pAttachments[" << i - << "], contains unsupported format"; - // TODO: Verify against Valid Use section of spec. Generally if something yield an undefined result, it's invalid - skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, - IMAGE_FORMAT_UNSUPPORTED, "IMAGE", "%s", ss.str().c_str()); - } - } - } for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { if (!validate_VkImageLayoutKHR(pCreateInfo->pAttachments[i].initialLayout) || -- cgit v1.2.3