From 5bc5421fb655a38afff00939afcdc1f2482f14b2 Mon Sep 17 00:00:00 2001 From: Michael Lentine Date: Thu, 28 Jan 2016 15:03:46 -0600 Subject: layers: Check that queryFlags is valid if enabled. --- layers/device_limits.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'layers/device_limits.cpp') diff --git a/layers/device_limits.cpp b/layers/device_limits.cpp index 54d01769..5a7111c6 100644 --- a/layers/device_limits.cpp +++ b/layers/device_limits.cpp @@ -51,6 +51,7 @@ #include "vulkan/vk_layer.h" #include "vk_layer_config.h" #include "vulkan/vk_debug_marker_layer.h" +#include "vk_enum_validate_helper.h" #include "vk_layer_table.h" #include "vk_layer_debug_marker_table.h" #include "vk_layer_data.h" @@ -550,6 +551,13 @@ VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuf DEVLIMITS_INVALID_INHERITED_QUERY, "DL", "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support inheritedQueries."); } + if (dev_data->actualPhysicalDeviceFeatures.inheritedQueries != VK_FALSE && pInfo && pInfo->occlusionQueryEnable != VK_FALSE && + !validate_VkQueryControlFlagBits(VkQueryControlFlagBits(pInfo->queryFlags))) { + skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast(commandBuffer), __LINE__, + DEVLIMITS_INVALID_INHERITED_QUERY, "DL", + "Cannot enable in occlusion queries in vkBeginCommandBuffer() and set queryFlags to %d which is not a valid combination of VkQueryControlFlagBits.", + pInfo->queryFlags); + } if (!skipCall) dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); } -- cgit v1.2.3