From 30d58922251a62b7d06b7d1382b8ac5afb03fc25 Mon Sep 17 00:00:00 2001 From: Mark Lobodzinski Date: Wed, 1 Mar 2017 13:58:47 -0700 Subject: layers: Add drawIndirectFirstInstance feature TODOs Change-Id: Iba54a78bc72ef169faeb6ce3e92b392c738e0bbe --- layers/core_validation.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'layers/core_validation.cpp') diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index 56fdf57f..5a2d4d89 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -7566,6 +7566,8 @@ static bool PreCallValidateCmdDrawIndirect(layer_data *dev_data, VkCommandBuffer VALIDATION_ERROR_01381, VALIDATION_ERROR_02234); *buffer_state = GetBufferState(dev_data, buffer); skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02544); + // TODO: If the drawIndirectFirstInstance feature is not enabled, all the firstInstance members of the + // VkDrawIndirectCommand structures accessed by this command must be 0, which will require access to the contents of 'buffer'. return skip; } @@ -7599,6 +7601,9 @@ static bool PreCallValidateCmdDrawIndexedIndirect(layer_data *dev_data, VkComman VALIDATION_ERROR_01393, VALIDATION_ERROR_02272); *buffer_state = GetBufferState(dev_data, buffer); skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02545); + // TODO: If the drawIndirectFirstInstance feature is not enabled, all the firstInstance members of the + // VkDrawIndexedIndirectCommand structures accessed by this command must be 0, which will require access to the contents of + // 'buffer'. return skip; } -- cgit v1.2.3