From bdf7c5add72c664bbc71336f6dc849294d3e456a Mon Sep 17 00:00:00 2001 From: Petr Kraus Date: Fri, 5 Jan 2018 04:05:12 +0100 Subject: layers: Make ValidateGreaterThan report vuid etc. - make ValidateGreaterThan report proper vuid and other log_msg parameters - make ValidateGreaterThanZero to avoid having to convert common 0 literal (for template deduction) - update check and remove redundant ones in core_validation --- layers/buffer_validation.cpp | 9 --------- 1 file changed, 9 deletions(-) (limited to 'layers/buffer_validation.cpp') diff --git a/layers/buffer_validation.cpp b/layers/buffer_validation.cpp index 112972f0..b2268277 100644 --- a/layers/buffer_validation.cpp +++ b/layers/buffer_validation.cpp @@ -709,15 +709,6 @@ bool PreCallValidateCreateImage(layer_data *device_data, const VkImageCreateInfo VkDeviceSize imageGranularity = GetPhysicalDeviceProperties(device_data)->limits.bufferImageGranularity; imageGranularity = imageGranularity == 1 ? 0 : imageGranularity; - // TODO : This is also covering 2918 & 2919. Break out into separate checks - if ((pCreateInfo->extent.width <= 0) || (pCreateInfo->extent.height <= 0) || (pCreateInfo->extent.depth <= 0)) { - skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, __LINE__, - VALIDATION_ERROR_09e007b8, "Image", - "CreateImage extent is 0 for at least one required dimension for image: " - "Width = %d Height = %d Depth = %d. %s", - pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth, - validation_error_map[VALIDATION_ERROR_09e007b8]); - } // TODO: VALIDATION_ERROR_09e00770 VALIDATION_ERROR_09e00772 VALIDATION_ERROR_09e00776 VALIDATION_ERROR_09e0076e // All these extent-related VUs should be checked here -- cgit v1.2.3