From 616c407893a935101d2e3ba0812dcacc2b3e303f Mon Sep 17 00:00:00 2001 From: Juan Ramos Date: Fri, 21 Oct 2022 10:36:55 -0600 Subject: ci: Use MACOS_DEPLOYMENT_TARGET - This approach matches what our SDK release process expect - Since setting CMAKE_MACOS_DEPLOYMENT_TARGET ignores env variable which SDK release process uses, which could will cause issues in the future, if the version is changed - CMAKE_MACOS_DEPLOYMENT_TARGET doesn't propogate to dependencies via update_deps.py --- .github/workflows/build.yml | 4 ++++ 1 file changed, 4 insertions(+) (limited to '.github/workflows') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a7a38728..af8e6364 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -111,6 +111,10 @@ jobs: - name: Generate build files run: cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=${{matrix.config}} -Cexternal/helper.cmake + env: + # Specify the minimum version of macOS on which the target binaries are to be deployed. + # https://cmake.org/cmake/help/latest/envvar/MACOSX_DEPLOYMENT_TARGET.html + MACOSX_DEPLOYMENT_TARGET: 10.12 - name: Build the tools run: make -C build -- cgit v1.2.3