aboutsummaryrefslogtreecommitdiff
path: root/layers
AgeCommit message (Collapse)Author
2016-06-21Revert "layers: Update docs for shared utils DLL"Mark Lobodzinski
This reverts commit 94dd6081959103c1c9b0bcfda173d4149d5555b9. Change-Id: Ie5b437d822c5efe6baf0baf2830591f50bf3ee4d
2016-06-22layers: Fix CmdBeginRenderPass after non-inline renderpass in same CBChris Forbes
Fixes #667. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-21layers: GH669, Fix clearValueCount errorsMark Lobodzinski
Validation was assuming LOAD_OP_CLEAR for some attachments resulting in bad validation messages. Change-Id: I8ff75ca63f591e3002b1ee2b61a6844d0cf1c07d
2016-06-21layers: Fix Windows crash in Dota2Mark Lobodzinski
In core_validation attachment_references_compatible(), having array elements set to VK_ATTACHMENT_UNUSED was not handled resulting in invalid memory references. Change-Id: If78aea1467d191db905272bece16cc9f56643136
2016-06-20layers: Get rid of fence->swapchain linkChris Forbes
Nothing used this after rationalizing the state tracking. Change-Id: I67cc267336b5d64bea9645a8e0a072885db58c26 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Untangle validate+update in QueuePresentKHRChris Forbes
Change-Id: I8f719c6e57cbab836b90f30414e6494a0643580e Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Fix AcquireNextImageKHR handling of sync objectsChris Forbes
Change-Id: I3e5a5d08763c0bf26c6c69aecf4bcef17d055a48 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Add getSemaphoreNode helperChris Forbes
Change-Id: Iceda3b28474e289189ef1f97b271f9e9bb7b2083 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Rework fence state trackingChris Forbes
Instead of having a combination of firstTimeFlag, in_use, and needsSignaled, let's just have an enum with the three states a fence can actually be in. Change-Id: I6a40cd709717c75740c9977b149c4f71a02a27ab Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Tidy decrementResources a bitChris Forbes
Change-Id: Ib8f9a917115323d8d43b971593b213ff04138a35 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: use getFenceNode in decrementResourcesChris Forbes
Change-Id: I8351405299f2f109489fdddfc111412164aded77 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Pass layer_data to verifyWaitFenceStateChris Forbes
Change-Id: Id3e0f09254197119b821710f0e9ce27d3458afc9 Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: use getFenceNode in verifyWaitFenceStateChris Forbes
Change-Id: I46f4ef4c225e199c0415507bd19dc4ffc98a77bc Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Remove some MT leftoversChris Forbes
Change-Id: I2b62475951315c6b231342be6f7c74865e3ea2bb Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-20layers: Add DSAspectBitsErrors test to documentationTobin Ehlis
2016-06-20layers: GH644 Validate DS image aspect bit restrictionTobin Ehlis
If a DS image is used in a descriptor, regardless of the underlying image layout, we need to validate that BOTH DEPTH and STENCIL aspect bits are NOT set. Only one of the two bits is allowed.
2016-06-20tests: Update documentation with RenderPassIncompatible testTobin Ehlis
2016-06-20layers: Add bug fix to handle NULL attachment caseTobin Ehlis
Correctly handle null resolve attachment case. When verifying attachment compatibility, matching null resolves is ok.
2016-06-20layers: Add PSO render pass compability checkTobin Ehlis
At draw time, the active render pass must be compatible with the render pass that the gfx pipeline was created with.
2016-06-20tests: Update doc to note BindImageInvalidMemoryType is disabledTobin Ehlis
2016-06-20layers: GH656, Fix CreateRenderpass validationMark Lobodzinski
In the core_validation layer, much of the validation was occurring AFTER the API call had been made. Separated validation and tracking. Change-Id: I6f8502d52dd2861a18254de48141a3736ced257f
2016-06-20layers: Fix dynamic descriptor countTobin Ehlis
When creating descriptor set layout, we were only incrementing the dynamic descriptor count by 1 regardless of the number of descriptors in a binding. This fix increments the count by the number of descriptors in the binding.
2016-06-20layers: Update manifest files for vers 1.0.17Karl Schultz
Change-Id: Ifdce033092a72980e1ff685792d486d2a101f35d
2016-06-17layers: GH401, Break out stencil load/storeOp checkMark Lobodzinski
Stencil attachment load/storeOp settings were being ignored. Added format appropriate checks for these flags. Change-Id: I6a917fc8a28cbb0d0441152e8d6630defb1b81e3
2016-06-17layers: GH576, Update layer details docMark Lobodzinski
Added entries for new attachment index tests and enums. Change-Id: Ida1de0bffc544718e63ccf3641a09dbe577f3c4d
2016-06-17layers: GH576, Validate attachment image usageMark Lobodzinski
Framebuffer attachment images are created with IMAGE_USAGE flags. These flags are now validated against their attachment location in subpass description structures. Also added a check for a preserve attachment being set to UNUSED and fixed a few typos in the attachment index checking stuff. Change-Id: Id62d3539c490ce8f381d7ae606402980f11946fa
2016-06-16layers: LX539, update layer details docMark Lobodzinski
Added new error enum for memory index type mismatches. Change-Id: I6f857facc4209f103da5cef9f6561a0e4ec3c334
2016-06-16layers: LX539, Validate mem typesMark Lobodzinski
Bind[Image|Buffer]Memory did not validate that the memoryPropertyType matched the memory_requirements memory type flags for the buffer or image. Change-Id: I7007588d78408689c34df66a17cc9201a37569b1
2016-06-15tests: GH421 vkUpdateDescriptorSets testsMark Mueller
A) Adding the WriteDescriptorSetIntegrityCheck test, which verifies some requirements of chapter 13.2.3 of the Vulkan Spec 1) A uniform buffer update must have a valid buffer index. 2) When using an array of descriptors in a single WriteDescriptor, the descriptor types and stageflags must all be the same. 3) Immutable Sampler state must match across descriptors The above tests also exercise cases where descriptors are updated with consecutive bindings both correctly and incorrectly B) adding a MissingClearAttachment test that points to a wrong colorAttachment index in a VkClearAttachment structure passed to vkCmdClearAttachments C) update vk_validation_layer_details.md to reflect above changes. Change-Id: I3f4f2233371b68caf23b5a4111d63a94765121c3
2016-06-14layers: Fix CMakeLists.txt for non-MSVC Win buildsMark Mueller
Fix a recent change broke windows builds that don't use the VC IDE or decorate build trees like VC does Change-Id: I93c8a559c4255408a6fa890b2a3e4d81822d1cea
2016-06-13layers: Update docs for shared utils DLLMark Lobodzinski
Change-Id: I129b4d074f0604bbdf6d81c052333229ece99ac3
2016-06-13layers: Add debug report headerMark Lobodzinski
Enable output of a short message header containing definitions of debug message types. Change-Id: Ia84fb0e79d599b8d022b7d78267b7b6a0307823e
2016-06-13layers: Make vklayer_utils a shared libraryMark Lobodzinski
Was previously statically linked. Converting to a DLL will allow data sharing and use of utils in samples repo. Change-Id: I63ccc1f0f57dfad40f7068c60ac623bce5bd714d
2016-06-13layers: Fix Windows Dota2 crashMark Lobodzinski
One of the event tracking lists was not getting cleared upon a reset, resulting in an invalid reference on reuse. Change-Id: I45d932822f27197266b363634d6cdccc785209d3
2016-06-13layers: Fix test fallout in CommandBufferTwoSubmitsChris Forbes
This test was accidentally triggering the fence reuse case as well, and blindly continuing past that error. It doesn't need to use the fence at all, so don't supply one. Also tweak the layer to not run into the assert if the caller elected to skip -- QueueSubmit still has validation and updates tangled together, but this improves it slightly. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Fix mistracking of semaphores associated with submissionsChris Forbes
When a command buffer is simultaneously inflight multiple times, each can have different semaphores associated. Storing the set of semaphores on the GLOBAL_CB_NODE caused us to get confused and emit bogus errors. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Note broken behavior around stealing tracking from other queuesChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Add members to FENCE_NODE and QUEUE_NODE to hold the handlesChris Forbes
We'd like to be able to get back to them from the tracking struct. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Add helpers for getting fence and queue nodesChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Add CB_SUBMISSION structChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Unify fence checks for queue functionsChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Remove dead fence members from GLOBAL_CB_NODEChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: remove tracking of last queue and fence for CBChris Forbes
Unused. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-06-13layers: Update manifest files for vers 1.0.16Jon Ashburn
Change-Id: I7468c088d99f7bebabc05d1a84529f6e9e00d424
2016-06-10layers: GH536, Updated layer details docMark Lobodzinski
Added new cases, removed old enums, moved info from devlimits to parameter validation. Change-Id: Iddf6a679dc8596dcf411a6b880a63a26999607ec
2016-06-10layers: GH536, Update CmdFillBuffer validationMark Lobodzinski
Was ignoring VK_WHOLE_SIZE. Moved validation cases for Update/FillBuffer to Parameter Validation layer (as they were stateless) and added the remaining additional stateless valid usage checks. Change-Id: I0f41c6ba55f218a6db9fb34736a2abc52f856edf
2016-06-09layers: PR573, Handle imageArraySize renameDavid McFarland
Swapchain layer had stale references -- rename things still using imageArraySize instead of imageArrayLayers. Change-Id: Iaa4500ab8cf55e50b96636a50136605dd3e6d83e
2016-06-09layers: PR632, Updated layer details docMark Lobodzinski
Added device_limits MISSING_QUERY_COUNT Change-Id: I5b129ec12930129f5d5fe46bbe2622977dc2d992
2016-06-09layers: PR632, Change devlimits errors to warningsJan-Harald Fredriksen
Replace call sequence errors with warnings for vkEnumeratePhysicalDevices and GetPhysicalDeviceQueueFamilyProperties. Change-Id: I1505f4a2b339ac7ef435da8b3ec2f85612026a42
2016-06-09layers: PR629, Remove subpass warningsJan-Harald Fredriksen
The validation layer checks for dependency between subpasses using the same attachments, but it also issues warnings if there are "only" implicit dependencies between two subpasses. This is explicitly allowed by the spec and should not cause validation warnings. Change-Id: I1039955d6d445e1ee234116c6da2e4dbaf9c7dd9