aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-25docs: Fix .md syntax typo in headerRene Lindsay
2016-10-25scripts:Update unique error enums as of 10/25/16Tobin Ehlis
Two new checks, two killed checks, and one updated check this week. Cmd line used for update: python spec.py -update -remap 2270-2042
2016-10-24loader: Fix cast warningJamie Madill
Fix a cast warning found in loader.c. Change-Id: Ie39e84ce8f050a2655c2ad3a1a146dda17c15bf9
2016-10-21loader: gh610- More debug log messagesMark Young
Add more debug log messages for CreateDevice. Change-Id: Iba02facc479fab6a6f976addc94da3accf9541f4
2016-10-21externals: Update glslang revisionMark Young
Updated glslang to use commit 3fc1543794d1c368d690e60eaac6111c8c436aa7 from 10/20/2016. Change-Id: I016273fbe936abd2dd5c19f5ee9ce3e6d09d72e6
2016-10-21Adding input attachment access as optional for attachment optimal layouts.Jan-Harald Fredriksen
Change-Id: I0ef3d1af2ef38d218f1721e98eb1d98b326cd340
2016-10-21demos: Add src and dst stages to set_image_layoutTony Barbour
Change-Id: I70e70b8085cc1196b5ffb69283c158ea8bd7ec1b
2016-10-20tests: Add postive test group to validatelayerdoc scriptKarl Schultz
Change-Id: If8b1d81d4c755ba8fc409d141387291d0e7d813d
2016-10-20layers: More err enum work in obj_trackerKarl Schultz
Change-Id: I299b68ec2e66d77812ce5dff0d457e328cdd6c5c
2016-10-20demos: Fix access masks when cube uses staging bufferTony Barbour
Change-Id: I89655f8224c3543d9c57f2cf7bd55b2c2a21c09f
2016-10-19scripts:Fix valid usage parsingTobin Ehlis
Fixes #1067 Original valid usage parsing was naive and in how it used "strong" tags to disable valid usage parsing which led to missing some checks and including some spec language that wasn't valid usage. This change isolates valid usage parsing to sidebar blocks which will always contain the valid usage language. This prevents anything outside of a sidebar from being incorrectly caught as valid usage and it also catched a number of valid usage cases that were missed with previous parser. There are about 50 valid usage cases removed and about 300 added.
2016-10-19layers: Reword from cryptic abbreviations to readable wordsMike Weiblen
Expand abbreviations to improve readability: DS=depth/stencil DS=descriptor set CB=command buffer VS=vertex shader FS=fragment shader VTX=vertex PSO=pipeline state object Change-Id: I48fe917aac50d1911fe2a3aa1ed2c739637c7645
2016-10-19layers: Fix core_validation function declarationsMike Stroyan
Add VKAPI_ATTR to FlushMappedMemoryRanges and InvalidateMappedMemoryRanges function declarations.
2016-10-19tests: Add ValErrorId support to ErrorMonitorMark Lobodzinski
SetDesiredMessage is now overloaded to take a string or a unique error enum ID (VALIDATION_ERROR_xxxxx) to identify a particular message. Passing in VALIDATION_ERROR_MAX_ENUM will match all messages for positive tests. Also updated a couple of tests to use error enums instead of strings. Change-Id: Ic7723cf88ea6bda57d89ab82aace6ed358b14382
2016-10-18demos: Fix misspellingMike Weiblen
Change-Id: I044619fb70b0a77dcbcdfe7c72dc8915119239a3
2016-10-18layers:Fix cmd buffer to buffer bindingTobin Ehlis
Bind the buffer to the cmd buffer independent of the buffer memory. Previously in the null memory case we'd bind the cmd buffer to the buffer without binding the buffer to the cmd buffer. This fixes that imbalance.
2016-10-18layers:Fix memory cleanup at DestroyImage timeTobin Ehlis
Need to ClearMemoryObjectBindings() when an image is destroyed. Do this even if mem_info is NULL which it will be for sparse bindings.
2016-10-18layers:Update memory helper funcs to use BINDABLETobin Ehlis
When getting, setting & clearing memory bindings, work with the updated BINDABLE superclass of IMAGE & BUFFER state objects.
2016-10-18layers:Add BINDABLE superclass for image/buffer stateTobin Ehlis
Support for sparse memory binding is virually non-existant in current validation layers. This is a first step down a long path to improve sparse binding support. The BINDABLE superclass is sub-classed by IMAGE & BUFFER state objs and contains memory binding info in both the single binding and sparse binding cases. Bindings are initially encapsulated in the new MEM_BINDING struct. For single binding cases, things are almost exactly the same as they have always been. For sparse binding, the various bindings will be stored in the sparse_bindings set where we initally don't have complete information on the sparse binding as we only store the MEM_BINDING info but this is a start.
2016-10-18demos: Cube barrier changes from GH #1033Tony Barbour
Change-Id: Ic68f9cd722474dc74957625c23c0f801f4b3852c
2016-10-18layers:Kill blank array element for empty bindingTobin Ehlis
Fixes #1053 DescriptorLayout class was incrementing global index for empty bindings which led to an empty array entry that could cause invalid errors when updating descriptors. This change will only increment global index for non-empty bindings.
2016-10-18header: Update vulkan.hpp to version 1.0.31Mark Lobodzinski
Change-Id: Ia81cef98ef59431255e608d3a3faecfc4368ef8d
2016-10-18loader: Update SOVERSION to version 1.0.31Mark Lobodzinski
Change-Id: If2e6d7dee62d03cfc95bebd8418c53bceef6fc22
2016-10-18layers: Update layer json files to version 1.0.31Mark Lobodzinski
Change-Id: I0f88d1c5572b643d83168095d95a3f33c6d5b837
2016-10-18header: Move vulkan.h. to version 1.0.31Mark Lobodzinski
Change-Id: I854442c5ef7f42b380766fd24aa11ef48dfb4ffb
2016-10-18header: Move vk.xml to version 1.0.31Mark Lobodzinski
Change-Id: If908ba18545c4afc0d041904c0daa57a2569c5a9
2016-10-18layers:Fix Val IDs msg calls forTobin Ehlis
Two CmdCopyImage checks were looking up the incorrect strings for their error enums. Use the correct strings.
2016-10-18scripts:Update spec script to include extensionsTobin Ehlis
Moving all of the validation error enums from the vanilla 1.0 script to the script that includes all of the extensions. Took a bit of script wizardry and lots of back and forth to get all of the new checks matching the old ones. I think everything is there from the original except for 4 layer checks (enums 1661-1664) that were all invalid errors. For reference here's the complete command line used to migrate: python spec.py -update -remap 628-619:708-671:729-689:732-692:762-722:\ 1251-1203:1253-1204:1256-1206:1258-1207:1315-1263:1320-1268:1322-1269:\ 1364-1310:1366-1311:1369-1313:1371-1314:1555-1458:1684-1584:1697-1597:\ 1960-1679,3:1945-1665,13:1963-1683,11
2016-10-18layers: Fix bad use of PIPELINE_STATE ptr value in errorsChris Forbes
Fixes #1056. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-10-17loader: Fix vkDestroySurfaceKHR call on NULL surfMark Young
Thanks to Derrick Owens @ AMD for catching this bug which can cause a null-ptr dereference while running Khronos conformance test dEQP-VK.wsi.win32.surface.destroy_null_handle. Change-Id: I104a890cd23615458566ec71e072e21c76e989cb
2016-10-17demos: fix cubepp on wayland errorsJeremy Hayes
Change-Id: I74fe07d170ee0e403357a018554ac9d6c754b6b5
2016-10-14external: Update spirv and glslang revisionsMark Young
Updated spirv-tools, spirv-headers, and glslang to latest commits in their respective repositories. Change-Id: Ic6543f827de2311a3e88d6e97bedcc0e77d7086a
2016-10-14loader: Fix compilation warning in debug_report.cMark Young
Change-Id: I92e7f23217ef3897995514360c23849ef1cfadeb
2016-10-14layers: Update CmdCopyImage validation for styleMark Lobodzinski
Updated function/var names for layer coding style guidelines. Change-Id: Ia9bcc2bd1c87e0e5f49d0d5996c030d727d971d2
2016-10-14layers: Add Val IDs for a more cmdCopyImage checksMark Lobodzinski
A couple more of the CmdCopyImage checks that have LVTs got added. One of the remaining ones is not covered by valid usage but is a 'must' check, will add later. Change-Id: Id9a1b7ad276c159149be4ef8c29d845baae29a35
2016-10-14layers: GH1055, Update unique validation IDsMark Lobodzinski
For CmdCopyImage bounds checks. Change-Id: Ifb0f9916df9f0ee50815733c990f3e4397565e7e
2016-10-14layers: Updated validation database for new checksMark Lobodzinski
Updated entries for new CmdCopyImage tests. Change-Id: I3511da9c4e335fbd25eef0b60be5d4f9cc12a4d0
2016-10-14layers: Add error message header to image layerMark Lobodzinski
Change-Id: I12afb66f2ba6de940f3257e52c5073690acd3d45
2016-10-14layers: GH1055, Add bounds checks for CmdCopyImageMark Lobodzinski
Added missing bounds-checking code. Change-Id: Ia65b8bb22e6c580c3ebbb26409ddfbf5dcb683b6
2016-10-14layers:Kill old MTMERGE definesTobin Ehlis
Just a couple of these lingering that we can now axe
2016-10-14layers: Suppress warning generation after app acknowledges an errorChris Forbes
The app already knows about the problem-- it has requested that the call be skipped. Producing another warning afterward is just noise. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-10-14layers: Stop copying INSTANCE_STATE into deviceChris Forbes
V2: Squash in second patch; resolve conflicts with @tobine's renames. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-10-13layers:Pipeline state rename fixupTobin Ehlis
Overzealous bulk replace changed getPipelineLayout to getPipelineState layout. This should not have been changed so reverting here.
2016-10-13layers:Rename IMAGE_NODE to IMAGE_STATETobin Ehlis
Another node->state rename pass.
2016-10-13layers:Refactor DestroyImageTobin Ehlis
Add validation flag for DestroyImage and update it to follow the Pre/Post pattern.
2016-10-13layers:Refactor DestroyRenderPassTobin Ehlis
Add validation flag for DestroyRenderPass and update it to follow the Pre/Post pattern.
2016-10-13layers:Rename RENDER_PASS_NODE to *_STATETobin Ehlis
Another node->state rename pass.
2016-10-13layers:Bind descriptor pool to cmd bufferTobin Ehlis
Add pool state to DescriptorSet instead of just the pool. Then, at bind time, create a dual binding between the cmd buffer and the pool. This correcly puts pool in-use when cmd buffer is submitted, as well as flagging cmd buffer as INVALID if/when the pool is destroyed.
2016-10-13layers:Update some pool_node namingTobin Ehlis
Change some pool_node names to pool_state in DescriptorSet class. Also update getPool function prototype to the new name of getDescriptorSetState().
2016-10-13layers:Add pool member to DescriptorSet classTobin Ehlis
When creating a DescriptorSet instance, record the pool that the set is allocated from in a private pool_ variable. Then, when binding a set to a cmd buffer, also create a binding between the command buffer and the pool. This allows us to catch the in-use case when sets are implicitly freed by calling vkDestroyDescriptorPool().