aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-02layers: s/skip_call/skip/ in CV CreateComputePipelinesChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-12-02layers: CV: null out pipelines on validation failureChris Forbes
If we don't call down the chain, creation of all the pipelines failed. Callers expect to inspect the handles for partial success -- don't leave uninitialized junk here. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-12-02layers: Switch sense of logic in CV CreateGraphicsPipelinesChris Forbes
No functional change. Drop the explicit unlocks -- this happens as the unique_lock goes out of scope anyway. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-12-01loader: const fixesFrank Henigman
Make the 'source_override' parameter of loader_get_manifest_files() const. The const was removed in 74d013a5, seemingly for convenience of calling loader_free_getenv(), not because it was incorrect. Give loader_free_getenv() the same signature in all implementations. Fix a memory leak where it was possible to exit loader_get_manifest_files() without calling loader_free_getenv(). Don't pass a potentially NULL value to loader_log().
2016-12-01loader: Modify conversion of real_icd_surfacesMark Young
This is the more appropriate way to cast the real_icd_surfaces values than downcasting the pointer. This is based off of Jamie Madill's changes. Change-Id: If63fb95994a92199d65fd3297bb092564446af97
2016-12-01loader: Fix cast warning in wsi.cJamie Madill
In 32-bits, this was downcasting a VkSurfaceKHR and comparing it with NULL. Since VkSurfaceKHR is defined as a uint64_t, it's better to cast the NULL to a VkSurfaceKHR to avoid a warning.
2016-12-01loader: avoid DEFAULT_VK_LAYERS_PATH redefinition.Frank Henigman
Commit df441f60 did this in the win32 section of the file, but missed the linux section. This commit fixes the linux section.
2016-12-01loader: spell 'separator' correctlyFrank Henigman
PATH_SEPERATOR -> PATH_SEPARATOR
2016-11-29scripts:Update unique error enums as of 11/29/16Tobin Ehlis
This was a beast of an update. Reconfiguration in the spec caused various section numbers to move which created a need to remap a ton of ids. Also a large bulk of new valid usage blocks for new extensions as well as legitimate addition and subtraction of core valid usage statements. I'd focus some time on updating the script to handle these cases better but now that Khronos has agreed to integrating the ids into the spec itself, that will eliminate the need for the updates once the integration is complete so I'll focus my efforts there going fwd and hopefully only have to perform 1 or 2 more of these updates. That resulted in the following cmd line to do the update: python spec.py -update -remap 182-166,85:273-252,18:301-270,49:\ 397-368,15:919-768:2076-1600,61:2340-1665,13:697-1719:2137-1794,30:\ 2169-1824,7:2176-1834:2178-1831,3:2181-1836,4:2185-1843:2187-1840,3:\ 2190-1844,39:2233-1883,40:2284-1923,39:2324-1962,16:2348-1978:\ 2354-1979:2368-1980,7:2375-1988:2376-1990:2377-1998,24:2418-2043,12:\ 2402-2022,15:2417-2040:167-2059:268-2067,5:291-2072,10:2355-1679,2:\ 2357-1683,11:2229-2327,4:2401-2343:2273-2331,11:2323-2342
2016-11-29toolchain: Switch back to tracked revisions on AndroidCody Northrop
This allows us to recreate the entire LVL package from any point in history. We continue to pull known good revisions from AOSP.
2016-11-29misc: Make update external bat not clean buildLenny Komow
Change-Id: Ief2218fb83fb1916b8fcabe60f48893e9393121e
2016-11-29layers: Updated error enum DB for KHR_DISPLAY modMark Lobodzinski
Change-Id: I988a5975647b337b057fe79e92ec74c746dcde9d
2016-11-29layers: Complete support for VK_KHR_Display extNorbert Nopper
Fixed using display extension only crash. Added vkGetDisplayPlaneCapabilitiesKHR. Fixes, that unique objects works for display extension. Change-Id: I66727a430b9d55bfa40fdddc884f40c91aa29f11
2016-11-29layers: Revert some include order changes in PVChris Forbes
Windows build is cranky about this -- if things are done in the wrong order, we can end up with some symbols in the dispatch table being mangled to their W-suffixed versions thanks to windows.h madness. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Move surface format tracking to CVChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Note swapchain replacement rules may be out of dateChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Move present modes tracking to CVChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Remove some noise from PV, add to authorsChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Fix broken use of phys device as device dispatch keyChris Forbes
This made no sense. The physical device's dispatch key is the same as the instance. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: move device dispatch table into layer_data in PVChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Move dispatch table into instance_layer_dataChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: get rid of instance_extension_map in PVChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: split PV layer data for device and instanceChris Forbes
Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Remove extra 'no depth/stencil attachments exist' errorChris Forbes
This is now covered by other fairly clear errors. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-29layers: Remove bogus CreateSharedSwapchainsKHR impl in swapchainChris Forbes
This wasn't even wired up. Parameter validation also now does these checks. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-28layers: GH1131, Add error enums to object trackerMike Schuchardt
Added error enums to object_tracker.cpp and updated vk_validation_error_database.txt check_implemented column to match Change-Id: Icdd08ef50316be023b218b0b36a997a8a61e2a1e
2016-11-28layers: Remove handrolled clipped / sharingMode validation fromChris Forbes
swapchain PV now does this Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-28layers: Tweak PV generator to track newly introduced enums separatelyChris Forbes
Within each feature block, we need to generate a helper value for 'all valid bits'. This worked fine; however, across features blocks an enum may be used -- for example, core eums used in extension functions. Previously, we'd clear out all the enums we know about at the feature boundary, which left various fields unvalidated. Signed-off-by: Chris Forbes <chrisforbes@google.com>
2016-11-23build: Fix cube.cpp build issues for WaylandKarl Schultz
Fixes #1190 Change-Id: Iefb03b803b049a1634ae2075178afbd3dee691bd
2016-11-23scripts:Mark 639 unimplemented in the databaseTobin Ehlis
I believe VALIDATION_ERROR_00639 was marked as implemented because the case is handled in parameter_checker, but the code itself has not been updated so I'm switching it back to 'N' in the database for now until the error code is actually updated.
2016-11-23scripts:Add exception for error 1790Tobin Ehlis
VALIDATION_ERROR_01790 is a special case that provides an exception for valid usage when VK_AMD_negative_viewport_height extension is enabled. There's no actual error to flag here, but the code does handle the exception case correctly so adding it as an exception in the stat script as well to reflect that it's implemented.
2016-11-23tests:Update AllocDescriptorFromEmptyPoolTobin Ehlis
Update the AllocDescriptorFromEmptyPool test with a new case where we attempt to allocate more sets than available. Update the error checking for both cases to use the unique error enum instead of string matching. Also update database file to reflect new test case.
2016-11-23layers:Unique enums for vkAllocateDescriptorSetsTobin Ehlis
Add appropriate unique error enums to the code for allocating descriptor sets from a pool without enough sets left and without enough descriptors left. These were already flagged as implemented but the enums hadn't been added to the code.
2016-11-23layers:Separate push constant max size errorsTobin Ehlis
There's separate valid usage language regarding the relationship between a device's maxPushConstantsSize and the size and offset of VkPushConstantRange. Splitting up the validation callbacks to flag these two errors separately along with their respective unique error enums.
2016-11-23layers:Separate two error checksTobin Ehlis
There's separate valid usage language for VkPushConstantRange size being non-zero and being multiple of 4. Breaking the validation callbacks to flag these two errors separately along with their respective unique error enums.
2016-11-23layers: Handle partial failure in vkCreate*PipelinesMaciej Jesionowski
This applies to vkCreate*Pipelines creating multiple objects with a single call. Creation of *some* pipelines may fail and an error code will be returned. In this case invalid handles will be set to NULL, and the remaining handles must be managed properly.
2016-11-23externals: Update glslang and spriv-tools revisionMark Young
Update glslang to commit 1c573fb and spirv-tools to commit 6fa6a37. Change-Id: I22692c213fdc1bada0ee14f110373b1d8c76b043
2016-11-23layers: Fix windows build warningsMark Lobodzinski
Change-Id: Ifead20bae1e3c4f237ffc6f49422f20621b6349e
2016-11-23tests: GH1182, Add buffer/image copy test casesMark Lobodzinski
Added cases to MiscImageLayerTest and updated the VE database. Change-Id: Ic76d9c5aafc1532cc761c92feaffbf5745e86f93
2016-11-23layers: GH1182, Validate VkBufferImageCopy depthMark Lobodzinski
Validate that for buffer<-->image copies that (for 1D and 2D image types) the offset is 0 and the depth is 1. Change-Id: I8114ce78be926411a2938148bf4c60d86006f8a4
2016-11-23layers: Removed obsolete CV validation checksMark Lobodzinski
Removed obsolete CopyImageToBuffer/CopyBufferToImage checks that output errors if the layerCount was zero and removed corresponding LVT. Change-Id: I0a2bada5f896c30fb13cad8a4b3fe157d6d788d3
2016-11-23layers: Moved image/buffer aspect checkMark Lobodzinski
Moved this validation check into a routine shared by both copyImageToBuffer and copyBufferToImage. Change-Id: If53581cb7dd847492f52b9c2c95b0be25654074f
2016-11-23layers: Update ValidateBufferImageCopyData err enumsMark Lobodzinski
Updated enums and database. Change-Id: If04fa10a233ffab9a1622a6bcdaad803de9c84a6
2016-11-23layers: Update BufferImageCopy var names for styleMark Lobodzinski
Change-Id: If39d85522b27e571ab3e7c0e9fb8cc4e63ac0cf9
2016-11-23layers: Update call structure for BufferImageCopiesMark Lobodzinski
Converted over to PreCallValidate structure for CmdCopyImageToBuffer and CmdCopyBufferToImage. Change-Id: I9e68376bbcaa4c7058eb820b55125c524983b1be
2016-11-23layers: Clarify BufferImageCopy validation nameMark Lobodzinski
This routine was used in both ImageToBuffer and BufferToImage but the name was misleading. Change-Id: I8ff99cff1757dbaa888cf543451e6a3a4872b003
2016-11-22layers: Fix BindImageMemory typoMark Lobodzinski
Change-Id: I77359a73635d4cdae066255e774a096a9b643a3e
2016-11-22layers:Avoid copy of cmd buffer setTobin Ehlis
No need to copy the entire unordered_set<GLOBAL_CB_NODE *> in invalidateCommandBuffers(). Change it to take a "const &" instead.
2016-11-22layers:Use ptr to cmd buffer object in log_msgTobin Ehlis
This new error was incorrectly referencing the ptr to the cb_node, which is internal validation state, instead of the cmd buffer object that the node wraps.
2016-11-22scripts: Improve paths in update_ext_resources.shMark Lobodzinski
Script was relying on $PWD for determining the current path which is unreliable in some situations. Updated to a more robust method allowing spaces in paths. Change-Id: Ibdb780c479ad7fa831d113e445cc598830806806