aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorMike Schuchardt <mikes@lunarg.com>2018-03-09 09:02:56 -0700
committerMike Schuchardt <mikes@lunarg.com>2018-03-09 13:54:31 -0700
commitd430624d1078c844ca6f51242df76299213327b2 (patch)
treee88b71d941291bb36109306ece4851dc6e8962d1 /scripts
parenta67b097c2a44fbdcdc09e48250b60e7d4458b37f (diff)
downloadusermoji-d430624d1078c844ca6f51242df76299213327b2.tar.xz
scripts: helper_file_generator.py cleanup
- Remove list as set anti-pattern - Remove conditional that could never evaluate to False
Diffstat (limited to 'scripts')
-rw-r--r--scripts/helper_file_generator.py13
1 files changed, 3 insertions, 10 deletions
diff --git a/scripts/helper_file_generator.py b/scripts/helper_file_generator.py
index ab0ceed5..1468b150 100644
--- a/scripts/helper_file_generator.py
+++ b/scripts/helper_file_generator.py
@@ -182,18 +182,11 @@ class HelperFileOutputGenerator(OutputGenerator):
groupElem = groupinfo.elem
# For enum_string_header
if self.helper_file_type == 'enum_string_header':
- value_list = []
+ value_set = set()
for elem in groupElem.findall('enum'):
if elem.get('supported') != 'disabled' and elem.get('alias') == None:
- item_name = elem.get('name')
- # Avoid duplicates
- if item_name not in value_list:
- value_list.append(item_name)
- if value_list is not None:
- #if alias:
- # self.enum_output += self.GenerateEnumStringConversion(alias, value_list)
- #else:
- self.enum_output += self.GenerateEnumStringConversion(groupName, value_list)
+ value_set.add(elem.get('name'))
+ self.enum_output += self.GenerateEnumStringConversion(groupName, value_set)
elif self.helper_file_type == 'object_types_header':
if groupName == 'VkDebugReportObjectTypeEXT':
for elem in groupElem.findall('enum'):