diff options
| author | Bob Ellison <bob@lunarg.com> | 2020-07-15 15:15:28 -0600 |
|---|---|---|
| committer | Bob Ellison <45772930+lunarpapillo@users.noreply.github.com> | 2020-07-15 18:30:22 -0600 |
| commit | d093d9723b7c6c8387a99fca8714d9fba600fc6a (patch) | |
| tree | a1c623e8f0695f1805d89b86b7e1273e0492bf33 /scripts | |
| parent | 76034e2ac62e3fd3d95554b06a6db603203be634 (diff) | |
| download | usermoji-d093d9723b7c6c8387a99fca8714d9fba600fc6a.tar.xz | |
scripts: fix update_deps retry clone
There was a subtle bug in the original change; "git fetch"
would retry correctly, but "git clone" failed because the
destination directory was missing (after having been removed,
to ensure a clean clone operation).
The test case that was used (hundreds of times) happened to
provoke an error on the "git fetch" path; I was unaware that
the "git clone" failure path had never been exercised.
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/update_deps.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/update_deps.py b/scripts/update_deps.py index 658dcf54..ea21c9fb 100755 --- a/scripts/update_deps.py +++ b/scripts/update_deps.py @@ -345,8 +345,8 @@ class GoodRepo(object): def Clone(self, retries=10, retry_seconds=60): print('Cloning {n} into {d}'.format(n=self.name, d=self.repo_dir)) - distutils.dir_util.mkpath(self.repo_dir) for retry in range(retries): + distutils.dir_util.mkpath(self.repo_dir) try: command_output(['git', 'clone', self.url, '.'], self.repo_dir) # If we get here, we didn't raise an error |