diff options
| author | Courtney Goeltzenleuchter <courtneygo@google.com> | 2016-01-14 16:06:06 -0700 |
|---|---|---|
| committer | Jon Ashburn <jon@lunarg.com> | 2016-01-20 18:05:30 -0700 |
| commit | d67187f62af471d76ec973c6357b1abe6d96c5f3 (patch) | |
| tree | d902af1854d26614155c476d41213db5eca87843 /loader | |
| parent | 1d9335f18426322551f89af4a2c848aff57212dc (diff) | |
| download | usermoji-d67187f62af471d76ec973c6357b1abe6d96c5f3.tar.xz | |
loader: remove resolved TODOs
Diffstat (limited to 'loader')
| -rw-r--r-- | loader/loader.c | 10 | ||||
| -rw-r--r-- | loader/trampoline.c | 1 |
2 files changed, 2 insertions, 9 deletions
diff --git a/loader/loader.c b/loader/loader.c index 8c896512..2f253f00 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -2882,7 +2882,7 @@ VkResult loader_create_instance_chain(const VkInstanceCreateInfo *pCreateInfo, lib_handle = loader_add_layer_lib(inst, "instance", layer_prop); if (!lib_handle) - continue; // TODO what should we do in this case + continue; if ((fpGIPA = layer_prop->functions.get_instance_proc_addr) == NULL) { if (layer_prop->functions.str_gipa == NULL || strlen(layer_prop->functions.str_gipa) == 0) { fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, "vkGetInstanceProcAddr"); @@ -2891,8 +2891,6 @@ VkResult loader_create_instance_chain(const VkInstanceCreateInfo *pCreateInfo, fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gipa); if (!fpGIPA) { loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetInstanceProcAddr in layer %s", layer_prop->lib_name); - - /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/ continue; } } @@ -3096,7 +3094,7 @@ VkResult loader_create_device_chain( lib_handle = loader_add_layer_lib(inst, "device", layer_prop); if (!lib_handle) - continue; // TODO what should we do in this case + continue; if ((fpGIPA = layer_prop->functions.get_instance_proc_addr) == NULL) { if (layer_prop->functions.str_gipa == NULL || strlen(layer_prop->functions.str_gipa) == 0) { fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, "vkGetInstanceProcAddr"); @@ -3105,8 +3103,6 @@ VkResult loader_create_device_chain( fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gipa); if (!fpGIPA) { loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetInstanceProcAddr in layer %s", layer_prop->lib_name); - - /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/ continue; } } @@ -3118,8 +3114,6 @@ VkResult loader_create_device_chain( fpGDPA = (PFN_vkGetDeviceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gdpa); if (!fpGDPA) { loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetDeviceProcAddr in layer %s", layer_prop->lib_name); - - /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/ continue; } } diff --git a/loader/trampoline.c b/loader/trampoline.c index d525158d..35f0853b 100644 --- a/loader/trampoline.c +++ b/loader/trampoline.c @@ -187,7 +187,6 @@ LOADER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance( *pInstance = created_instance; /* - * TODO: This can go away now? * Finally have the layers in place and everyone has seen * the CreateInstance command go by. This allows the layer's * GetInstanceProcAddr functions to return valid extension functions |