diff options
| author | Mark Lobodzinski <mark@lunarg.com> | 2016-01-06 12:56:29 -0700 |
|---|---|---|
| committer | Mark Lobodzinski <mark@lunarg.com> | 2016-01-06 14:37:14 -0700 |
| commit | 3cfbc376b505956db26d6a09d6468f9bad831784 (patch) | |
| tree | 47e323e5b8119b2163e7291b2edad086cd3597c9 /layers | |
| parent | c0a4e7a918754c3cd405c6118f49babfd25b32fd (diff) | |
| download | usermoji-3cfbc376b505956db26d6a09d6468f9bad831784.tar.xz | |
layers: LX259, Clarify draw_state accessMask warnings
Diffstat (limited to 'layers')
| -rw-r--r-- | layers/draw_state.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/layers/draw_state.cpp b/layers/draw_state.cpp index 121f5839..a43e89f3 100644 --- a/layers/draw_state.cpp +++ b/layers/draw_state.cpp @@ -4571,6 +4571,7 @@ std::string string_VkAccessFlags(VkAccessFlags accessMask) // AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. // If required_bit is zero, accessMask must have at least one of 'optional_bits' set +// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions VkBool32 ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, const char* type) { VkBool32 skip_call = false; @@ -4585,7 +4586,7 @@ VkBool32 ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, } else { if (!required_bit) { skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", - "%s AccessMask %d %s must contain at least one of access bits %d %s when layout is %s.", + "%s AccessMask %d %s must contain at least one of access bits %d %s when layout is %s, unless the app has previously added a barrier for this transition.", type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); } else { @@ -4594,7 +4595,7 @@ VkBool32 ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, opt_bits = "and may have optional bits " + std::to_string(optional_bits) + ' ' + string_VkAccessFlags(optional_bits); } skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", - "%s AccessMask %d %s must have required access bit %d %s %s when layout is %s.", + "%s AccessMask %d %s must have required access bit %d %s %s when layout is %s, unless the app has previously added a barrier for this transition.", type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); |