aboutsummaryrefslogtreecommitdiff
path: root/layers/core_validation.cpp
diff options
context:
space:
mode:
authorTobin Ehlis <tobine@google.com>2017-01-03 11:23:30 -0700
committerTobin Ehlis <tobine@google.com>2017-01-04 06:49:18 -0700
commitecca0899be558bc29947d89077f380905f70300a (patch)
treecdc3d7eae5f8eae4ea6411d9a2373de1ad774135 /layers/core_validation.cpp
parent0b1930efac0a3580119b2e2216c20df069a47910 (diff)
downloadusermoji-ecca0899be558bc29947d89077f380905f70300a.tar.xz
layers:Remove redundant image compatibility check
The format compatibility check when creating an image view handles case of color-color check as well as compressed image compatibility check. Killing the redundant check and comment as this is all handled above.
Diffstat (limited to 'layers/core_validation.cpp')
-rw-r--r--layers/core_validation.cpp12
1 files changed, 0 insertions, 12 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp
index f3ed5370..c3edf928 100644
--- a/layers/core_validation.cpp
+++ b/layers/core_validation.cpp
@@ -6637,18 +6637,6 @@ static bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageVi
// Validate correct image aspect bits for desired formats and format consistency
skip |= ValidateImageAspectMask(dev_data, image_state->image, image_format, aspect_mask, "vkCreateImageView()");
- if (vk_format_is_color(image_format) && !vk_format_is_color(view_format)) {
- std::stringstream ss;
- ss << "vkCreateImageView: The image view's format can differ from the parent image's format, but both must be "
- << "color formats. ImageFormat is " << string_VkFormat(image_format) << " ImageViewFormat is "
- << string_VkFormat(view_format);
- skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
- (uint64_t)create_info->image, __LINE__, VALIDATION_ERROR_02171, "IMAGE", "%s %s", ss.str().c_str(),
- validation_error_map[VALIDATION_ERROR_02171]);
- // TODO: Uncompressed formats are compatible if they occupy they same number of bits per pixel.
- // Compressed formats are compatible if the only difference between them is the numerical type of
- // the uncompressed pixels (e.g. signed vs. unsigned, or sRGB vs. UNORM encoding).
- }
}
return skip;
}