diff options
| author | Chris Forbes <chrisforbes@google.com> | 2016-09-27 17:14:46 +1300 |
|---|---|---|
| committer | Chris Forbes <chrisforbes@google.com> | 2016-09-30 09:38:13 +1300 |
| commit | 748f51dbe657b98c1a8de9d3d605e101578bc159 (patch) | |
| tree | 4ebf7bba9a6f3b650570d42f4b027b98060aabe9 /layers/core_validation.cpp | |
| parent | c8780b573013c4e786c857e15d15088067b6adb5 (diff) | |
| download | usermoji-748f51dbe657b98c1a8de9d3d605e101578bc159.tar.xz | |
layers: Use cmd buffer as src object in callback
One less TODO.
Signed-off-by: Chris Forbes <chrisforbes@google.com>
Diffstat (limited to 'layers/core_validation.cpp')
| -rw-r--r-- | layers/core_validation.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index 1edaa2ce..a513989f 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -8289,13 +8289,13 @@ VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, ui // Warn if this is issued prior to Draw Cmd and clearing the entire attachment if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { - // TODO : commandBuffer should be srcObj // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must // call CmdClearAttachments // Otherwise this seems more like a performance warning. skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, - VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", + VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), + 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", (uint64_t)(commandBuffer)); |
