diff options
| author | Chris Forbes <chrisforbes@google.com> | 2017-05-08 10:58:00 -0700 |
|---|---|---|
| committer | Chris Forbes <chrisf@ijw.co.nz> | 2017-05-08 12:05:53 -0700 |
| commit | 61f22e844a29726ce3915171c9e0e26579d67fec (patch) | |
| tree | 9961a4b01d04b1d73ab210d80562fc31564b3515 /layers/core_validation.cpp | |
| parent | 4f2e41960b6f28ec3b3877f7beff13811ca54af3 (diff) | |
| download | usermoji-61f22e844a29726ce3915171c9e0e26579d67fec.tar.xz | |
layers: Remove unhelpful precheck in ValidateDrawState
Diffstat (limited to 'layers/core_validation.cpp')
| -rw-r--r-- | layers/core_validation.cpp | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index 31c76680..7c6beeb8 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -2655,26 +2655,6 @@ static bool ValidateDrawState(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, con } else { // Valid set is bound and layout compatible, validate that it's updated // Pull the set node cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; - // Gather active bindings - std::unordered_set<uint32_t> active_bindings; - for (auto binding : set_binding_pair.second) { - active_bindings.insert(binding.first); - } - // Make sure set has been updated if it has no immutable samplers - // If it has immutable samplers, we'll flag error later as needed depending on binding - if (!descriptor_set->IsUpdated()) { - for (auto binding : active_bindings) { - if (!descriptor_set->GetImmutableSamplerPtrFromBinding(binding)) { - result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, - VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)descriptor_set->GetSet(), - __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", - "Descriptor Set 0x%" PRIxLEAST64 - " bound but was never updated. It is now being used to draw so " - "this will result in undefined behavior.", - (uint64_t)descriptor_set->GetSet()); - } - } - } // Validate the draw-time state for this descriptor set std::string err_str; if (!descriptor_set->ValidateDrawState(set_binding_pair.second, state.dynamicOffsets[setIndex], cb_node, function, |