diff options
| author | Tobin Ehlis <tobine@google.com> | 2017-08-22 13:11:23 -0600 |
|---|---|---|
| committer | Tobin Ehlis <tobine@google.com> | 2017-08-22 14:36:40 -0600 |
| commit | 21a839577afeb834f10bf1feb7cae16e66a08702 (patch) | |
| tree | ff537cb293c7dc481ef9a0f822149678a73850d5 /layers/core_validation.cpp | |
| parent | 58dd95d322e6ca78560bf95d15255c2664f92e50 (diff) | |
| download | usermoji-21a839577afeb834f10bf1feb7cae16e66a08702.tar.xz | |
layers:Remove disturbed descriptor perf warning
Fixes #2020
Support from devs to remove this perf warning so just killing it.
Added a comment for future work where we can track which descriptors
are disturbed and reference that if a user attempts to use a
disturbed descriptor that isn't bound.
Also commented out associated test and filed #2022 to track enhancement
making note of disturbed descriptors if used unbound.
Diffstat (limited to 'layers/core_validation.cpp')
| -rw-r--r-- | layers/core_validation.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index 6088f814..9a6dd942 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -5490,14 +5490,8 @@ VKAPI_ATTR void VKAPI_CALL CmdBindDescriptorSets(VkCommandBuffer commandBuffer, if (cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[i] && !verify_set_layout_compatibility(cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[i], pipeline_layout, i, error_string)) { - skip |= log_msg( - dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, - VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, - HandleToUint64(cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[i]), __LINE__, DRAWSTATE_NONE, - "DS", "DescriptorSet 0x%" PRIxLEAST64 - " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", - HandleToUint64(cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[i]), i, - HandleToUint64(layout)); + // TODO: Flag descriptor as disturbed and then if/when attempt to be used when unbound, note that it was + // previously disturbed cb_state->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; } } |